Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

FBSDKCoreKit, FBSDKLoginKit, FBSDKShareKit Info.plist files are missing proper CFBundleVersion. #12

Closed
AndrewBarba opened this issue Jul 15, 2016 · 12 comments

Comments

@AndrewBarba
Copy link

I think version 4.14 (CoreKit and LoginKit) are missing the $(CURRENT_PROJECT_VERSION) which gets set as CFBundleVersion in the Info.plist. I can confirm that the FBSDKCoreKit.framework in my local Carthage/Build folder is missing this key in the info.plist

@nlutsenko
Copy link
Contributor

Yup, looks absolutely correct.
ObjC FBSDK has a slightly different release cycle than us (Swift SDK), meaning that releasing a fix for it won't be as fast.

Any chance CocoaPods is an option for you?
You could also always just change that Info.plist key manually, but there is no current way of automating that.

@AndrewBarba
Copy link
Author

Okay makes sense. And yes, I have to use both Carthage and Cocoapods anyway so I'll just switch this sdk to CP for now. Do you want me to open the same issue in the other repo?

@AndrewBarba
Copy link
Author

Hm nevermind, I don't think I can open issues in the other repo. If you could pass the word along, that would be awesome.

@nlutsenko
Copy link
Contributor

Yup, creating an internal task and submitting a fix for it as well right now.

@AndrewBarba
Copy link
Author

Amazing, really appreciate it. Thanks for the rapid responses

@nlutsenko nlutsenko changed the title Cannot upload to iTunes Connect: FBSDKCoreKit.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion FBSDKCoreKit, FBSDKLoginKit, FBSDKShareKit Info.plist files are missing proper CFBundleVersion. Jul 15, 2016
@JagCesar
Copy link

I just ran into the same issue, any eta on when this might be fixed @nlutsenko?

Thanks a bunch for creating this sdk btw. We can finally get rid of cocoa pods :)

@nlutsenko
Copy link
Contributor

😁 The patch was merged upstream internally and it should be out with the next version of ObjC SDK in a few weeks.

@arsonik
Copy link
Contributor

arsonik commented Aug 24, 2016

Hey, Any update on the ETA ?
Thanks alot !

@ashchan
Copy link
Contributor

ashchan commented Aug 28, 2016

The iOS SDK v4.15 has been released two days ago. I tried updating my local carthage dependencies and it seems CFBundleVersion is properly set (as 4.15.0).

@nlutsenko
Copy link
Contributor

Hey guys, the bug is fully fixed now as of 4.15.0 of ObjC SDK. Yay!

This means that if you are using any package manager (like CocoaPods or Carthage) - you can get it today and successfully ship apps to App Store.

I am going to update few of the things in the Swift SDK in the upcoming days and we are going to ship 0.2 of it, which is likely to be the last Swift 2.3 release (Swift 3 GM is coming soon!), but it will also update all the references to the ObjC SDK, so everyone even installing from scratch always get the latest and greatest version.

@JagCesar
Copy link

These are great news! Keep up the good work guys! 👊🏼❤️

@Kacper20
Copy link

Kacper20 commented Dec 1, 2016

Hi @nlutsenko

Am I seeing this right that version of Swift SDK (0.2.0) which should work(is backed by 4.15 of ObjC SDK) is Swift 3.0 only? Is there any way to use Carthage with Swift 2.3? Currently I can't build project properly because of bissing CFBundleVersion in Info.plist

Thanks for help,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants