You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
The file has typechecks which will complain if you pass anything other than a function to it. We should also probably add flow types too, but I do not believe we should modify runtime behavior to verify it's a function.
The typechecks or the flow types only make sense when you compile this source code. But most time the libs we used are installed from npm and compiled, and all the types or checks are missed. by then the condition is different.
Yeah that will be true of typechecks probably, but for flow we can provide external library definitions. Doesn't matter if the module is transpiled or not
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
https://github.com/facebook/emitter/blob/master/src/EmitterSubscription.js#L32
there is no validation on the param
listener
and no
appliable
check when apply the listener.https://github.com/facebook/emitter/blob/master/src/BaseEventEmitter.js#L182
can we add some checks or make some noises when create a new EmitterSubscription?
The text was updated successfully, but these errors were encountered: