This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Fixes HTML importer to make image entity immutable #2184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@claudiopro merged this pull request in b858f43. |
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
) Summary: **Summary** Makes image entities created with the HTML importer immutable This diff also adds the `flow` annotation to the `convertFromHTMLToContentBlocks` test case and fixes typechecking failures that are surfaced by its addition. To support a more modern syntax to handle nullable fields, it adds the `babel/plugin-proposal-optional-chaining` plugin to Babel config. Fixes facebookarchive#2149 **Test Plan** Adds tests to verify created entities are immutable Pull Request resolved: facebookarchive#2184 Reviewed By: j-nolan Differential Revision: D17474930 Pulled By: claudiopro fbshipit-source-id: c60ef368ff471914c2e188277a0ecc050115533b
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
) Summary: **Summary** Makes image entities created with the HTML importer immutable This diff also adds the `flow` annotation to the `convertFromHTMLToContentBlocks` test case and fixes typechecking failures that are surfaced by its addition. To support a more modern syntax to handle nullable fields, it adds the `babel/plugin-proposal-optional-chaining` plugin to Babel config. Fixes facebookarchive#2149 **Test Plan** Adds tests to verify created entities are immutable Pull Request resolved: facebookarchive#2184 Reviewed By: j-nolan Differential Revision: D17474930 Pulled By: claudiopro fbshipit-source-id: c60ef368ff471914c2e188277a0ecc050115533b
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Makes image entities created with the HTML importer immutable This diff also adds the `flow` annotation to the `convertFromHTMLToContentBlocks` test case and fixes typechecking failures that are surfaced by its addition. To support a more modern syntax to handle nullable fields, it adds the `babel/plugin-proposal-optional-chaining` plugin to Babel config. Fixes facebookarchive/draft-js#2149 **Test Plan** Adds tests to verify created entities are immutable Pull Request resolved: facebookarchive/draft-js#2184 Reviewed By: j-nolan Differential Revision: D17474930 Pulled By: claudiopro fbshipit-source-id: c60ef368ff471914c2e188277a0ecc050115533b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes image entities created with the HTML importer immutable
This PR also adds the
@flowannotation to theconvertFromHTMLToContentBlockstest case and fixes typechecking failures that are surfaced by its addition.To support a more modern syntax to handle nullable fields, it adds the
@babel/plugin-proposal-optional-chainingplugin to Babel config.Fixes #2149
Test Plan
Adds tests to verify created entities are immutable