Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latent 32-bit make check warnings #3411

Closed
embg opened this issue Jan 5, 2023 · 1 comment
Closed

Latent 32-bit make check warnings #3411

embg opened this issue Jan 5, 2023 · 1 comment

Comments

@embg
Copy link
Contributor

embg commented Jan 5, 2023

We have some latent mingw gcc 32-bit make check warnings (when compiling with -Wall):

In function 'BIT_getLowerBits',
    inlined from 'BIT_addBits' at ../lib/compress/../common/bitstream.h:184:27,
    inlined from 'ZSTD_encodeSequences_body' at ../lib/compress/zstd_compress_sequences.c:316:5,
    inlined from 'ZSTD_encodeSequences_default' at ../lib/compress/zstd_compress_sequences.c:392:12,
    inlined from 'ZSTD_encodeSequences' at ../lib/compress/zstd_compress_sequences.c:437:12:
../lib/compress/../common/bitstream.h:171:35: warning: array subscript 32 is above array bounds of 'const unsigned int[32]' [-Warray-bounds]
  171 |     return bitContainer & BIT_mask[nbBits];
      |                           ~~~~~~~~^~~~~~~~

These warnings existed in dev at least three weeks ago (see the logs on this job). It's hard to bisect this because I don't have an msys2 setup locally, and very old CI job logs are not in retention any more. Opening an issue to track this because it might be release-blocking.

@embg embg added release-blocking Must be done by the release and removed release-blocking Must be done by the release labels Jan 5, 2023
@embg
Copy link
Contributor Author

embg commented Jan 5, 2023

Discussed with @terrelln, the warnings are bogus.

@embg embg closed this as completed Jan 5, 2023
@embg embg changed the title Latent 32-bit build failure Latent 32-bit make check warnings Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant