Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add-brand-page #757

Merged
merged 11 commits into from
Oct 31, 2024
Merged

feat: add-brand-page #757

merged 11 commits into from
Oct 31, 2024

Conversation

p0nch000
Copy link
Contributor

@p0nch000 p0nch000 commented Oct 24, 2024

What changed / motivation?

I added a "brand" page to the StyleX website, similar to the one on React Dev. The goal was to make it easier for users to access brand assets, including dark and light mode logos and colors, by simply right-clicking on the StyleX logo. This allows for a more user-friendly experience when working with StyleX branding materials.

Linked PR/Issues

Fixes #733

Additional Context

Screenshots:

  • A modal appears upon right-clicking the StyleX logo, allowing users to download the SVG files and copy brand colors for both dark and light modes.
  • The modal includes clear sections for dark mode, light mode, and additional assets like cover photos.
image Captura de pantalla 2024-10-24 a la(s) 4 08 15 p m

Tests:

  • Tested the modal in both light and dark modes.
  • Verified that the download and clipboard functionalities work as expected.

No breaking changes.

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2024
@p0nch000 p0nch000 changed the title chore: add-brand-page feat: add-brand-page Oct 24, 2024
Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, but some changes needed:

  1. There's a bunch of code quality improvements that need to be made to new component you have built.
  2. The branch needs to be rebased on the main branch. Currently it's pulling in a bunch of incomplete Playground code.

apps/docs/components/LogoDownloadModal.js Outdated Show resolved Hide resolved
apps/docs/components/LogoDownloadModal.js Outdated Show resolved Hide resolved
apps/docs/components/LogoDownloadModal.js Outdated Show resolved Hide resolved
apps/docs/components/LogoDownloadModal.js Outdated Show resolved Hide resolved
apps/docs/components/LogoDownloadModal.js Outdated Show resolved Hide resolved
apps/docs/components/LogoDownloadModal.js Outdated Show resolved Hide resolved
@nmn
Copy link
Contributor

nmn commented Oct 28, 2024

A good start. The design of the drop down looks good.

  • The dark mode SVG download works correctly. The light mode SVG download is broken.
  • The copy light mode color and copy dark mode color just copy color hashes. They should instead copy the SVG code.

@p0nch000
Copy link
Contributor Author

p0nch000 commented Oct 30, 2024

Hey I fixed everything you told me to fix, appreciate the feedback, im just having trouble to rebase with main, I think I already did it but still seeing those Playground files there after I've done it. Everything else already fixed!

UPDATE: I think I solved the rebase bug :))

@nmn

Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there. Make the suggested changes and ensure that there are no lint or prettier issues after.

Please run the following commands from the root of the repo.

$ npm run prettier
$ npm run lint

Thanks for the quick progress on this!

apps/docs/components/LogoDownloadModal.js Outdated Show resolved Hide resolved
apps/docs/components/LogoDownloadModal.js Show resolved Hide resolved
apps/docs/components/LogoDownloadModal.js Outdated Show resolved Hide resolved
apps/docs/components/LogoDownloadModal.js Outdated Show resolved Hide resolved
apps/docs/src/theme/Logo/index.js Outdated Show resolved Hide resolved
apps/docs/src/theme/Logo/index.js Outdated Show resolved Hide resolved
@p0nch000
Copy link
Contributor Author

p0nch000 commented Oct 30, 2024

Should be ready now, already used the prettier and lint commands from root, thanks for the patience and great feedback!!

@nmn

Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for now. Thanks!

@nmn nmn merged commit a73ed67 into facebook:main Oct 31, 2024
7 of 8 checks passed
Samantha-Zhan pushed a commit that referenced this pull request Nov 6, 2024
* Right click functionality (logo)
* Dialog element implemented
* Ability to download and copy SVGs
* Ability to download cover image
6ri4n pushed a commit to 6ri4n/stylex that referenced this pull request Nov 8, 2024
* Right click functionality (logo)
* Dialog element implemented
* Ability to download and copy SVGs
* Ability to download cover image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[website] Add a "brand" page to the website
3 participants