-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add-brand-page #757
feat: add-brand-page #757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, but some changes needed:
- There's a bunch of code quality improvements that need to be made to new component you have built.
- The branch needs to be rebased on the
main
branch. Currently it's pulling in a bunch of incomplete Playground code.
A good start. The design of the drop down looks good.
|
Hey I fixed everything you told me to fix, appreciate the feedback, im just having trouble to rebase with main, I think I already did it but still seeing those Playground files there after I've done it. Everything else already fixed! UPDATE: I think I solved the rebase bug :)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there. Make the suggested changes and ensure that there are no lint
or prettier
issues after.
Please run the following commands from the root of the repo.
$ npm run prettier
$ npm run lint
Thanks for the quick progress on this!
Should be ready now, already used the prettier and lint commands from root, thanks for the patience and great feedback!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for now. Thanks!
* Right click functionality (logo) * Dialog element implemented * Ability to download and copy SVGs * Ability to download cover image
* Right click functionality (logo) * Dialog element implemented * Ability to download and copy SVGs * Ability to download cover image
What changed / motivation?
I added a "brand" page to the StyleX website, similar to the one on React Dev. The goal was to make it easier for users to access brand assets, including dark and light mode logos and colors, by simply right-clicking on the StyleX logo. This allows for a more user-friendly experience when working with StyleX branding materials.
Linked PR/Issues
Fixes #733
Additional Context
Screenshots:
Tests:
No breaking changes.
Pre-flight checklist