From f81cebbfabf191816ad075d32acd8536fbb7d238 Mon Sep 17 00:00:00 2001 From: Luke Williams Date: Tue, 23 May 2017 18:43:03 -0400 Subject: [PATCH 1/3] Add warning: does not yet work with Android Relay just didn't work on Android for me. My investigation here: https://github.com/facebook/relay/issues/1797 Solution was posted here: https://github.com/facebook/relay/issues/1704#issuecomment-297982006 I think this is an invaluable warning to save other early adopters hours trying to dig into Relay Modern source and debug this issue. Thanks. --- docs/modern/Introduction.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/modern/Introduction.md b/docs/modern/Introduction.md index b7eca9b710fb6..82bc34b959fa1 100644 --- a/docs/modern/Introduction.md +++ b/docs/modern/Introduction.md @@ -99,3 +99,7 @@ One of the big ideas behind the new API is that execution can be made a lot more ## Comparing Relay Classic and Relay Modern Relay Modern enables a variety of new features. Some are available via the Compat API, while others require upgrading fully to the Modern runtime. See [what's new in Relay Modern](./new-in-relay-modern.html) for more details. + +## React Native + +Note that on Android, Relay Modern may not run properly because of an outstanding core-js issue. [This polyfill](https://github.com/facebook/relay/issues/1704#issuecomment-297982006) is a workaround until this issue is fixed. From 7722eff36b02501240d50288e86a27c06d6040b9 Mon Sep 17 00:00:00 2001 From: Luke Williams Date: Tue, 23 May 2017 18:44:52 -0400 Subject: [PATCH 2/3] Add additional info on what's broken "props don't load" --- docs/modern/Introduction.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/modern/Introduction.md b/docs/modern/Introduction.md index 82bc34b959fa1..9b1458746c559 100644 --- a/docs/modern/Introduction.md +++ b/docs/modern/Introduction.md @@ -102,4 +102,4 @@ Relay Modern enables a variety of new features. Some are available via the Compa ## React Native -Note that on Android, Relay Modern may not run properly because of an outstanding core-js issue. [This polyfill](https://github.com/facebook/relay/issues/1704#issuecomment-297982006) is a workaround until this issue is fixed. +Note that on Android, Relay Modern may not run properly (props don't load) because of an outstanding core-js issue. [This polyfill](https://github.com/facebook/relay/issues/1704#issuecomment-297982006) is a workaround until this issue is fixed. From 4c7a8bec9b891e567c1677eeca9afb581e633137 Mon Sep 17 00:00:00 2001 From: Luke Williams Date: Tue, 23 May 2017 18:49:56 -0400 Subject: [PATCH 3/3] Add link to RN thread --- docs/modern/Introduction.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/modern/Introduction.md b/docs/modern/Introduction.md index 9b1458746c559..38a7336a0ac2f 100644 --- a/docs/modern/Introduction.md +++ b/docs/modern/Introduction.md @@ -102,4 +102,4 @@ Relay Modern enables a variety of new features. Some are available via the Compa ## React Native -Note that on Android, Relay Modern may not run properly (props don't load) because of an outstanding core-js issue. [This polyfill](https://github.com/facebook/relay/issues/1704#issuecomment-297982006) is a workaround until this issue is fixed. +Note that on Android, [Relay Modern does not work](https://github.com/facebook/react-native/issues/13958) without a debugger attached (props will never be loaded). [This polyfill](https://github.com/facebook/relay/issues/1704#issuecomment-297982006) is a workaround until this issue is fixed.