[Fiber] Remove stack dependencies from tests #9080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Feb 28, 2017
| @@ -1071,14 +1070,13 @@ src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js | |||
| * gives source code refs for unknown prop warning for exact elements | |||
| * gives source code refs for unknown prop warning for exact elements in composition | |||
| * should suggest property name if available | |||
| * renders innerHTML and preserves whitespace | |||
| * render and then updates innerHTML and preserves whitespace | |||
gaearon
approved these changes
Feb 28, 2017
sebmarkbage
reviewed
Feb 28, 2017
| ReactDOM.unmountComponentAtNode(container); | ||
| expect(Object.keys(ReactMount._instancesByReactRootID).length).toBe(1); | ||
| }); | ||
|
|
There was a problem hiding this comment.
@gaearon I wonder if we should have a test that mocks__REACT_DEVTOOLS_GLOBAL_HOOK__ and then runs a copy of https://github.com/facebook/react-devtools/blob/master/backend/attachRenderer.js#L24 against it?
The purpose of this test is to ensure that we don't accidentally remove these hooks because they look unused.
There was a problem hiding this comment.
I'm less worried about those since the source is obviously devtools-related, unlike the name _instancesByReactRootID which I deleted at least once accidentally when I thought it was unused.
There was a problem hiding this comment.
Oh, we should just move the backend here. It's still on my todo list but I haven't gotten around to it.
sebmarkbage
approved these changes
Feb 28, 2017
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses points outlined in #9069, specifically:
src/renderers/__tests__/ReactUpdates-test.jshas been removedsrc/renderers/dom/shared/__tests__/ReactMount-test.jshas been removedsrc/renderers/dom/shared/__tests__/ReactDOMComponent-test.jshave been refactored to use the public API rather than internal Stack modulessrc/renderers/dom/shared/__tests__/ReactDOMIDOperations-test.jshas been refactored to use the public API and moved intosrc/renderers/dom/shared/__tests__/ReactDOMComponent-test.js