Consolidate hook events #7472
Merged
Consolidate hook events #7472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unnecessary. We now pass the element as part of onInstantiateComponent, and it can't change before mounting.
ghost
added
It is unused after #7410.
We already have onBeforeUpdateComponent. Let's just have on(Before?)(Mount|Update|Unmount)Component and stick with them. This removes double event dispatches in some hot spots.
The tests still pass so presumably it was not necessary.
|
Does this change ReactPerf output at all? |
|
No, this shouldn’t affect it. |
This lets us further consolidate hooks. The parent ID is now passed as an argument to onBeforeMountComponent() with the element.
| ); | ||
| return nextChildren; | ||
| } | ||
| } | ||
| nextChildren = flattenChildren(nextNestedChildrenElements); | ||
| nextChildren = flattenChildren(nextNestedChildrenElements, selfDebugID); |
There was a problem hiding this comment.
Interesting that we weren’t passing it before (this code path could still run in __DEV__).
There was a problem hiding this comment.
Hm, when is this._currentElement not set? Not even sure why we have that check.
| @@ -109,12 +109,17 @@ function mountComponentIntoNode( | |||
| console.time(markerName); | |||
| } | |||
|
|
|||
| var parentDebugID; | |||
| if (__DEV__) { | |||
There was a problem hiding this comment.
Can we drop these __DEV__ blocks?
It is unnecessary now that we pass the parent ID to onBeforeMountComponent.
This removes some awkward branching.
zpao
pushed a commit
that referenced
this pull request
Aug 12, 2016
* Remove onBeforeMountComponent hook event It is unnecessary. We now pass the element as part of onInstantiateComponent, and it can't change before mounting. * Remove onComponentHasMounted hook event It is unused after #7410. * Replace on(Begin|End)ReconcilerTimer hook events We already have onBeforeUpdateComponent. Let's just have on(Before?)(Mount|Update|Unmount)Component and stick with them. This removes double event dispatches in some hot spots. * Remove onComponentHasUpdated hook The tests still pass so presumably it was not necessary. * Add missing __DEV__ to TestUtils code * Replace on(InstantiateComponent|SetParent) with onBeforeMountComponent This lets us further consolidate hooks. The parent ID is now passed as an argument to onBeforeMountComponent() with the element. * Remove onMountRootComponent hook event It is unnecessary now that we pass the parent ID to onBeforeMountComponent. * Use parentDebugID = 0 both for roots and production This removes some awkward branching. (cherry picked from commit 0e976e1)
|
@zpao Note that this requires a Systrace change in RN I haven’t submitted yet. |
ghost
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 18, 2016
Summary: This brings RN up to date with facebook/react#7472 (scheduled for React 15.3.1). If you use React 15.3.1 with RN without this patch, Systrace output will lack the reconciler events. (Since it’s a niche feature it didn’t seem to me that full backward compat is necessary so I just removed old hooks. This won’t cause crashes—it’s just you won’t get events in Systrace if you use new React but old RN.) Closes #9383 Differential Revision: D3738463 Pulled By: spicyj fbshipit-source-id: 791cdbc5558666a101fa403f4e7852f700038fc9
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our DEV performance suffers because we have too many hook events right now.
I want to cut down on their number and be stricter in the future about adding more events.
I removed:
onInstantiateComponentonSetParentonComponentHasMountedonComponentHasUpdatedonBeginReconcilerTimeronEndReconcilerTimerInstead, I added
onBeforeUnmountComponent, and movedparentIDintoonBeforeMountComponent.As a result we now have a very simple (and small) hook event footprint for reconciliation:
onBeforeMountComponentandonMountComponentonBeforeUpdateComponentandonUpdateComponentonBeforeUnmountComponentandonUnmountComponentBasically a pair of events for every operation we support.
This will reqiure changes to RN and WTF integration.