ReactDebugToolEventForwarderDevTool

[troydemonbreun]

Per discussion with @jimfb on 6398

[troydemonbreun]

@jimfb I did not forward the *Flush and *Timer events in ReactDebugTool, should I do those as well?

[gaearon]

I think @sebmarkbage might have an opinion on this. Do we want all those events on both devtool integration points? Doesn't this increase (not yet public but eventually public) API surface quite a bit?

[jimfb]

I'm also curious to hear what @sebmarkbage thinks.

I really don't have a strong opinion here. Just seems like the React events are among the most critical events, so it would make sense that each renderer would supply them to the devtools as part of the same stream/registration process.

This also avoids an edge case where someone writes a renderer that happens to use an event name which React subsequently chooses to use. Any devtool listening to both React and MyReactRenderer would break. However, if the renderer is responsible for forwarding the event, it means that renderer can rename/modify/appendInfo as appropriate for the given event.

[troydemonbreun]

@jimfb Any interest from the team on this?

[gaearon]

@troydemonbreun

Sorry we didn’t come back to this. I believe @spicyj needed something similar in #6765 but went with a simpler option of adding any DOM devtools to ReactDebugTool automatically.

So this implementation appears no longer necessary, but an equivalent got merged. Thank you for the effort though!