Enable null return values in plain functions #5884
Merged
+56
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimfb
force-pushed
the
component-extends-react-component
branch
from
d8ef46a
to
d32aee5
Compare
|
|
||
| it('should allow simple functions to return false', function() { | ||
| function Child() { | ||
| return null; |
jimfb
force-pushed
the
component-extends-react-component
branch
from
d32aee5
to
757756f
Compare
|
@jimfb updated the pull request. |
|
🙌 |
|
Ping @sebmarkbage @spicyj |
|
I thought I reviewed this already. 👍 |
jimfb
added a commit
that referenced
this pull request
Jan 29, 2016
Enable null return values in plain functions
Merged
|
👍 |
afc163
added a commit
to react-component/table
that referenced
this pull request
Aug 2, 2016
gaearon
added a commit
to gaearon/react
that referenced
this pull request
Dec 28, 2016
This test is identical to "should warn when stateless component returns array" earlier. It was moved from another file in facebook#5884 so it likely survived by accident.
gaearon
added a commit
to gaearon/react
that referenced
this pull request
Dec 28, 2016
We have an invariant that checks the same case right afterwards. The warning was originally added in facebook#5884 with a distinct wording. However it was later changed to the same wording as the invariant in facebook#6008. I don't see why we would want to have both since they're saying the same thing and with (almost) the same internal stack.
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Jan 12, 2017
This test is identical to "should warn when stateless component returns array" earlier. It was moved from another file in facebook#5884 so it likely survived by accident.
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Jan 12, 2017
We have an invariant that checks the same case right afterwards. The warning was originally added in facebook#5884 with a distinct wording. However it was later changed to the same wording as the invariant in facebook#6008. I don't see why we would want to have both since they're saying the same thing and with (almost) the same internal stack.
10 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable null return values in plain functions by removing support for inheritless classes, as per #5355.