Issue #5839. Added onError event to the <source> #5861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alunyov
changed the title
alunyov
changed the title
|
@alunyov updated the pull request. |
|
@alunyov updated the pull request. |
|
Something happened to the PR. Do you mind cleaning it up so there’s just a single commit? |
|
@alunyov updated the pull request. |
|
@gaearon Sure, I will fix it. |
|
@alunyov updated the pull request. |
|
Hmm, this still doesn’t look right. |
Remove `load` event listener from the `<source>` element
|
@alunyov updated the pull request. |
|
@gaearon Sorry for that, I just pressed the wrong button :-). Now it should be fine. |
|
Tagging this as to be reviewed after 15.0 release. If everything is fine we’ll get this some time during 15.x. Thanks! |
|
@alunyov updated the pull request. |
|
Close it as #6941 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix onError event for the
<source>element.According to this article: http://www.w3schools.com/tags/tag_source.asp
<source>tag supports the events attributes in HTML. It's pretty close to an<img>tag.