Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] Stop reusing ScopeDep type in AnalyzeFunctions #30811

Merged
merged 3 commits into from
Aug 28, 2024
Merged

[compiler] Stop reusing ScopeDep type in AnalyzeFunctions #30811

merged 3 commits into from
Aug 28, 2024

Commits on Aug 26, 2024

  1. [compiler] Stop reusing ScopeDep type in AnalyzeFunctions 

    AnalyzeFunctions was reusing the `ReactiveScopeDependency` type since it happened to have a convenient shape, but we need to change this type to represent optionality. We now use a locally defined type instead.

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    cf27fa1 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Update on "[compiler] Stop reusing ScopeDep type in AnalyzeFunctions" 

    AnalyzeFunctions was reusing the `ReactiveScopeDependency` type since it happened to have a convenient shape, but we need to change this type to represent optionality. We now use a locally defined type instead.

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ca69ba4 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Update on "[compiler] Stop reusing ScopeDep type in AnalyzeFunctions" 

    AnalyzeFunctions was reusing the `ReactiveScopeDependency` type since it happened to have a convenient shape, but we need to change this type to represent optionality. We now use a locally defined type instead.

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    475e710 View commit details
    Browse the repository at this point in the history