Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Visit nested scopes in pruned scopes in PromoteUsedTemporaries #30537

Merged
merged 1 commit into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ class CollectPromotableTemporaries extends ReactiveFunctionVisitor<State> {
usedOutsideScope: false,
});
}
this.visitBlock(scopeBlock.instructions, state);
}

override visitScope(scopeBlock: ReactiveScopeBlock, state: State): void {
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@

## Input

```javascript
import {Stringify, identity, useIdentity} from 'shared-runtime';

function Foo({}) {
const x = {};
const y = {};
useIdentity(0);
return (
<>
<Stringify value={identity(y)} />
<Stringify value={identity(x)} />
</>
);
}

export const FIXTURE_ENTRYPOINT = {
fn: Foo,
params: [{}],
};

```

## Code

```javascript
import { c as _c } from "react/compiler-runtime";
import { Stringify, identity, useIdentity } from "shared-runtime";

function Foo(t0) {
const $ = _c(9);
const x = {};
const y = {};
useIdentity(0);

const T0 = Stringify;
const t1 = identity(y);
let t2;
if ($[0] !== T0 || $[1] !== t1) {
t2 = <T0 value={t1} />;
$[0] = T0;
$[1] = t1;
$[2] = t2;
} else {
t2 = $[2];
}
const T1 = Stringify;
const t3 = identity(x);
let t4;
if ($[3] !== T1 || $[4] !== t3) {
t4 = <T1 value={t3} />;
$[3] = T1;
$[4] = t3;
$[5] = t4;
} else {
t4 = $[5];
}
let t5;
if ($[6] !== t2 || $[7] !== t4) {
t5 = (
<>
{t2}
{t4}
</>
);
$[6] = t2;
$[7] = t4;
$[8] = t5;
} else {
t5 = $[8];
}
return t5;
}

export const FIXTURE_ENTRYPOINT = {
fn: Foo,
params: [{}],
};

```

### Eval output
(kind: ok) <div>{"value":{}}</div><div>{"value":{}}</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import {Stringify, identity, useIdentity} from 'shared-runtime';

function Foo({}) {
const x = {};
const y = {};
useIdentity(0);
return (
<>
<Stringify value={identity(y)} />
<Stringify value={identity(x)} />
</>
);
}

export const FIXTURE_ENTRYPOINT = {
fn: Foo,
params: [{}],
};