Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix incorrect polling #30531

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[ci] Fix incorrect polling #30531

merged 1 commit into from
Jul 30, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 30, 2024

Stack from ghstack (oldest at bottom):

Oops. Actually poll correctly by fetching the latest workflow run each
retry, and not just checking the first attempt.

Test plan: https://github.com/facebook/react/actions/runs/10165564989

[ghstack-poisoned]
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 3:46pm

poteto added a commit that referenced this pull request Jul 30, 2024
Oops

ghstack-source-id: 3202d8f6aeb1e1dead95d82a33c04dce80cd44b4
Pull Request resolved: #30531
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 30, 2024
@react-sizebot
Copy link

Comparing: 927ba57...be7f4d0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.29 kB 501.29 kB = 89.95 kB 89.95 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 508.41 kB 508.41 kB = 91.12 kB 91.12 kB
facebook-www/ReactDOM-prod.classic.js = 596.31 kB 596.31 kB = 105.76 kB 105.76 kB
facebook-www/ReactDOM-prod.modern.js = 572.61 kB 572.61 kB = 101.96 kB 101.96 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against c5aa8aa

poteto added a commit that referenced this pull request Jul 30, 2024
Oops. Actually poll correctly by fetching the latest workflow run each
retry, and not just checking the first attempt.

Test plan: https://github.com/facebook/react/actions/runs/10165564989

ghstack-source-id: 3202d8f6aeb1e1dead95d82a33c04dce80cd44b4
Pull Request resolved: #30531
@poteto poteto merged commit c5aa8aa into gh/poteto/3/base Jul 30, 2024
187 checks passed
poteto added a commit that referenced this pull request Jul 30, 2024
Oops. Actually poll correctly by fetching the latest workflow run each
retry, and not just checking the first attempt.

Test plan: https://github.com/facebook/react/actions/runs/10165564989

ghstack-source-id: 3202d8f6aeb1e1dead95d82a33c04dce80cd44b4
Pull Request resolved: #30531
@poteto poteto deleted the gh/poteto/3/head branch July 30, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants