[Fiber/DevTools] Stop injecting findHostInstanceByFiber #30519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
force-pushed
the
rmfindhostinstance
branch
from
f6f2cde
to
f3d2e65
Compare
kassens
approved these changes
Jul 29, 2024
|
Comparing: 87b1a94...af3ca9d Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
This is not used by DevTools since it has its own implementation of it. This function is getting removed since `findDOMNode` is getting removed so we shouldn't keep around extra bytes unnecessarily. There is also `findHostInstancesForRefresh` which should really be implemented on the `react-refresh` side. Not using an injection but that's a heavier lift and only affects `__DEV__`. DiffTrain build for commit bea5a2b.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
This is not used by DevTools since it has its own implementation of it. This function is getting removed since `findDOMNode` is getting removed so we shouldn't keep around extra bytes unnecessarily. There is also `findHostInstancesForRefresh` which should really be implemented on the `react-refresh` side. Not using an injection but that's a heavier lift and only affects `__DEV__`. DiffTrain build for [bea5a2b](bea5a2b)
I think we actually ended up never using that in any implementations so maybe it can just be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not used by DevTools since it has its own implementation of it.
This function is getting removed since
findDOMNodeis getting removed so we shouldn't keep around extra bytes unnecessarily.There is also
findHostInstancesForRefreshwhich should really be implemented on thereact-refreshside. Not using an injection but that's a heavier lift and only affects__DEV__.