[ci] Add commit steps to new runtime_commit_artifacts_v2 #30476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
poteto
commented
Jul 26, 2024
Comment on lines
+387
to
+392
| ${{ github.event.workflow_run.head_commit.message }} | ||
|
|
||
| DiffTrain build for commit https://github.com/facebook/react/commit/${{ github.event.workflow_run.head_sha }}. | ||
| branch: builds/facebook-fbsource | ||
| commit_user_name: ${{ github.event.workflow_run.actor.name }} | ||
| commit_user_email: ${{ github.event.workflow_run.actor.email || format('{0}@users.noreply.github.com', github.event.workflow_run.actor.name) }} |
Comment on lines
+229
to
+234
| ${{ github.event.workflow_run.head_commit.message }} | ||
|
|
||
| DiffTrain build for [${{ github.event.workflow_run.head_sha }}](https://github.com/facebook/react/commit/${{ github.event.workflow_run.head_sha }}) | ||
| branch: builds/facebook-www | ||
| commit_user_name: ${{ github.event.workflow_run.actor.name }} | ||
| commit_user_email: ${{ github.event.workflow_run.actor.email || format('{0}@users.noreply.github.com', github.event.workflow_run.actor.name) }} |
|
Comparing: 7f217d1...5de3bb8 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
poteto
added a commit
that referenced
this pull request
Jul 26, 2024
Adds back the missing steps with a few tweaks to where previously some `github` context value was referenced, I changed it to read from the triggering workflow_run (ie the build on `main`) instead. ghstack-source-id: 4b0fa135f059ba925647b12972fa67ae2a49f2db Pull Request resolved: #30476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Adds back the missing steps with a few tweaks to where previously some
githubcontext value was referenced, I changed it to read from thetriggering workflow_run (ie the build on
main) instead.