[compiler] printTerminal always prints instruction id #30397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing some debugging I noticed that a few of the newer terminals kinds weren't printing the instruction id. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
This was referenced Jul 19, 2024
Doing some debugging I noticed that a few of the newer terminals kinds weren't printing the instruction id. [ghstack-poisoned]
mofeiZ
approved these changes
Jul 19, 2024
Doing some debugging I noticed that a few of the newer terminals kinds weren't printing the instruction id. [ghstack-poisoned]
This was referenced Jul 23, 2024
josephsavona
added a commit
that referenced
this pull request
Jul 24, 2024
Doing some debugging I noticed that a few of the newer terminals kinds weren't printing the instruction id. ghstack-source-id: e0e4c96aeefdfe09d3be1527fd7103b4e506eb8e Pull Request resolved: #30397
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Doing some debugging I noticed that a few of the newer terminals kinds weren't printing the instruction id. ghstack-source-id: e0e4c96aeefdfe09d3be1527fd7103b4e506eb8e Pull Request resolved: facebook#30397
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Doing some debugging I noticed that a few of the newer terminals kinds weren't printing the instruction id. ghstack-source-id: e0e4c96aeefdfe09d3be1527fd7103b4e506eb8e Pull Request resolved: facebook#30397
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Doing some debugging I noticed that a few of the newer terminals kinds weren't printing the instruction id. ghstack-source-id: e0e4c96aeefdfe09d3be1527fd7103b4e506eb8e Pull Request resolved: facebook#30397
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Doing some debugging I noticed that a few of the newer terminals kinds weren't printing the instruction id. ghstack-source-id: e0e4c96aeefdfe09d3be1527fd7103b4e506eb8e Pull Request resolved: facebook#30397
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Doing some debugging I noticed that a few of the newer terminals kinds weren't printing the instruction id. ghstack-source-id: e0e4c96aeefdfe09d3be1527fd7103b4e506eb8e Pull Request resolved: facebook#30397
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Doing some debugging I noticed that a few of the newer terminals kinds weren't printing the instruction id. ghstack-source-id: e0e4c96aeefdfe09d3be1527fd7103b4e506eb8e Pull Request resolved: facebook#30397
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Doing some debugging I noticed that a few of the newer terminals kinds weren't printing the instruction id.