Commits on Jul 16, 2024

1. Result<T, E> defines isOk and isErr as type predicates: …

   ```ts
     // Returns `true` if the result is `Ok`.
     isOk(): this is OkImpl<T>;
     // Returns `true` if the result is `Err`.
     isErr(): this is ErrImpl<E>;
   ```
   
   The implementations just return `boolean`, which seems to break in TS 5.5:
   
   Running `tsc` in current `main`:
   ```
   tsc
   src/Utils/Result.ts:202:3 - error TS2416: Property 'isOk' in type 'ErrImpl<E>' is not assignable to the same property in base type 'Result<never, E>'.
     Type '() => boolean' is not assignable to type '() => this is OkImpl<never>'.
       Signature '(): boolean' must be a type predicate.
   
   202   isOk(): boolean {
         ~~~~
   
   src/Utils/Result.ts:206:3 - error TS2416: Property 'isErr' in type 'ErrImpl<E>' is not assignable to the same property in base type 'Result<never, E>'.
     Type '() => boolean' is not assignable to type '() => this is ErrImpl<E>'.
       Signature '(): boolean' must be a type predicate.
   
   206   isErr(): boolean {
   
   Found 38 errors in 7 files.
   
   Errors  Files
        2  src/HIR/BuildHIR.ts:196
        2  src/HIR/Environment.ts:745
        2  src/ReactiveScopes/CodegenReactiveFunction.ts:290
       14  src/Utils/Result.ts:96
        2  src/Validation/ValidateNoRefAccesInRender.ts:201
        2  src/Validation/ValidateNoSetStateInRender.ts:115
       14  src/__tests__/Result-test.ts:13
   
   ```sh
   tsc
   tsc --version
   Version 5.5.3
   ```

   

   nikeee committed Jul 16, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for cd72ada
   • Browse repository at this point

   Copy the full SHA

   cd72ada View commit details

   Browse the repository at this point in the history