Disable consoleWithStackDev Transform except in RN/WWW #30313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
added a commit
that referenced
this pull request
Jul 11, 2024
This code is getting deleted in #30313 anyway but it should've been gated all along. This code exists to basically manually transpile console.error to consoleWithStackDev because the transpiler doesn't work on `.apply` or `.bind` or the dynamic look up. We only apply the transform in DEV so we should've only done this in DEV. Otherwise these logs get silenced in prod.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
This code is getting deleted in #30313 anyway but it should've been gated all along. This code exists to basically manually transpile console.error to consoleWithStackDev because the transpiler doesn't work on `.apply` or `.bind` or the dynamic look up. We only apply the transform in DEV so we should've only done this in DEV. Otherwise these logs get silenced in prod. DiffTrain build for [a09950e](a09950e)
sebmarkbage
force-pushed
the
disableconsoleplugin
branch
from
6983e94
to
8411d18
Compare
hoxyq
reviewed
Jul 12, 2024
Comment on lines
-68
to
+67
| if (methodName === 'error' && __DEV__) { | ||
| error.apply(console, newArgs); | ||
| } else if (methodName === 'warn' && __DEV__) { | ||
| warn.apply(console, newArgs); | ||
| } else { | ||
| // $FlowFixMe[invalid-computed-prop] | ||
| console[methodName].apply(console, newArgs); // eslint-disable-line react-internal/no-production-logging | ||
| } | ||
| // $FlowFixMe[invalid-computed-prop] | ||
| console[methodName].apply(console, newArgs); // eslint-disable-line react-internal/no-production-logging |
There was a problem hiding this comment.
Looking at changes in facebook-www/ReactDOM-dev.modern.js, this could call original console methods?
Or are they guaranteed to be transformed at this point? So we end up calling same warn and error from consoleWithStackDev?
There was a problem hiding this comment.
They are not guaranteed to be transformed. This affects not just this but the Flight log replaying. In other words, it won't go through the warning module in www/rn. But both of these are only affecting Flight so we just need to figure that out once Flight when added to www what to do avoid Flight logs in www.
hoxyq
approved these changes
Jul 12, 2024
|
This PR itself currently leaves the transform on for RN OSS but #30320 removes that but I figured that's an independent decision. I can rebase the other PR. |
sebmarkbage
force-pushed
the
disableconsoleplugin
branch
from
8411d18
to
9c208af
Compare
In jest tests we're already not running the forks for RN/WWW so we don't need them at all there.
sebmarkbage
force-pushed
the
disableconsoleplugin
branch
from
9c208af
to
c83a110
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
Stacked on #30308. This is now a noop module so we can stop applying the transform of console.error using the Babel plugin in the mainline builds. I'm keeping the transform for RN/WWW for now although it might be nice if the transform moved into those systems as it gets synced instead of keeping it upstream. In jest tests we're already not running the forks for RN/WWW so we don't need it at all there. DiffTrain build for commit ff89ba7.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
Stacked on #30308. This is now a noop module so we can stop applying the transform of console.error using the Babel plugin in the mainline builds. I'm keeping the transform for RN/WWW for now although it might be nice if the transform moved into those systems as it gets synced instead of keeping it upstream. In jest tests we're already not running the forks for RN/WWW so we don't need it at all there. DiffTrain build for [ff89ba7](ff89ba7)
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Stacked on facebook#30308. This is now a noop module so we can stop applying the transform of console.error using the Babel plugin in the mainline builds. I'm keeping the transform for RN/WWW for now although it might be nice if the transform moved into those systems as it gets synced instead of keeping it upstream. In jest tests we're already not running the forks for RN/WWW so we don't need it at all there.
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #30308.
This is now a noop module so we can stop applying the transform of console.error using the Babel plugin in the mainline builds. I'm keeping the transform for RN/WWW for now although it might be nice if the transform moved into those systems as it gets synced instead of keeping it upstream.
In jest tests we're already not running the forks for RN/WWW so we don't need it at all there.