Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] Clone computation block in change detection mode #30148

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[compiler] Clone computation block in change detection mode #30148

merged 1 commit into from
Jul 1, 2024

Commits on Jun 30, 2024

  1. [compiler] Clone computation block in change detection mode 

    Summary: In change-detection mode, we previously were spreading the contents of the computation block into the result twice. Other babel passes that cause in-place mutations of the AST would then be causing action at a distance and breaking the overall transform result. This pr creates clones of the nodes instead, so that mutations aren't reflected in both places where the block is used.

[ghstack-poisoned]
    @mvitousek
    mvitousek committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    e6c1cd4 View commit details
    Browse the repository at this point in the history