Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add new lint GitHub action #30023

Merged
merged 3 commits into from
Jun 21, 2024
Merged

[ci] Add new lint GitHub action #30023

merged 3 commits into from
Jun 21, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Jun 21, 2024

[ghstack-poisoned]
Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 3:02pm

@poteto poteto mentioned this pull request Jun 21, 2024
poteto added a commit that referenced this pull request Jun 21, 2024
Copies the existing circleci workflow for linting into GitHub actions. I
didn't remove the circleci for now just to check for parity.

ghstack-source-id: 440dd5f9e7d10690b35a6f8adf227ba2bcc7e908
Pull Request resolved: #30023
@poteto poteto marked this pull request as draft June 21, 2024 14:47
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Jun 21, 2024
@poteto poteto marked this pull request as ready for review June 21, 2024 14:48
@react-sizebot
Copy link

react-sizebot commented Jun 21, 2024

Comparing: 49a4887...67febb6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js = 597.17 kB 597.17 kB = 105.33 kB 105.33 kB
facebook-www/ReactDOM-prod.modern.js = 571.52 kB 571.52 kB = 101.27 kB 101.27 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 67febb6

[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 21, 2024
Copies the existing circleci workflow for linting into GitHub actions. I
didn't remove the circleci for now just to check for parity.

ghstack-source-id: 235eea16251a9ac0ea8275fb2de40bb90b21492f
Pull Request resolved: #30023
[ghstack-poisoned]
Copy link
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting the GH Actions migration <3

@poteto poteto merged commit 67febb6 into gh/poteto/18/base Jun 21, 2024
51 checks passed
poteto added a commit that referenced this pull request Jun 21, 2024
Copies the existing circleci workflow for linting into GitHub actions. I
didn't remove the circleci for now just to check for parity.

ghstack-source-id: a3754dcc3bdf1b3fa7b8ca73b1554ef9fc9265b1
Pull Request resolved: #30023
@poteto poteto deleted the gh/poteto/18/head branch June 21, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants