toggle consoleManagedByDevToolsDuringStrictMode flag for native

[hoxyq]

Summary

Stacked on #29873, please review only the last commit.

The stack

1. This diff
2. chore[react-devtools]: improve console arguments formatting before passing it to original console #29873
3. chore[react-devtools]: unify console patching and default to ansi escape symbols #29869
4. chore[react-devtools/backend]: remove consoleManagedByDevToolsDuringStrictMode #29856

This enables consoleManagedByDevToolsDuringStrictMode flag for native.

Caution

Only land this and sync the renderers for Native once React DevTools backend version is updated.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 13, 2024 2:56pm

[react-sizebot]

Comparing: f5af92d...7fba323

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.js	=	6.66 kB	6.66 kB	=	1.82 kB	1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js	=	497.44 kB	497.44 kB	=	89.16 kB	89.16 kB
oss-experimental/react-dom/cjs/react-dom.production.js	=	6.67 kB	6.67 kB	=	1.83 kB	1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js	=	502.26 kB	502.26 kB	=	89.85 kB	89.85 kB
facebook-www/ReactDOM-prod.classic.js	=	596.94 kB	596.94 kB	=	105.24 kB	105.24 kB
facebook-www/ReactDOM-prod.modern.js	=	571.12 kB	571.12 kB	=	101.19 kB	101.19 kB
test_utils/ReactAllWarnings.js	Deleted	63.89 kB	0.00 kB	Deleted	15.97 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
react-native/implementations/ReactFabric-prod.js	+0.24%	311.76 kB	312.50 kB	+0.24%	54.67 kB	54.81 kB
react-native/implementations/ReactNativeRenderer-prod.js	+0.23%	320.73 kB	321.47 kB	+0.27%	56.32 kB	56.47 kB
react-native/implementations/ReactFabric-profiling.js	+0.22%	338.46 kB	339.20 kB	+0.25%	58.87 kB	59.01 kB
react-native/implementations/ReactNativeRenderer-profiling.js	+0.21%	348.07 kB	348.81 kB	+0.23%	60.68 kB	60.82 kB
react-native/implementations/ReactNativeRenderer-dev.js	=	598.14 kB	596.81 kB	=	98.98 kB	98.69 kB
react-native/implementations/ReactFabric-dev.js	=	587.10 kB	585.77 kB	=	96.65 kB	96.38 kB
test_utils/ReactAllWarnings.js	Deleted	63.89 kB	0.00 kB	Deleted	15.97 kB	0.00 kB

Generated by 🚫 dangerJS against 7fba323

[hoxyq]

@yungsters Could you please help me clarifying something?

1. Is this the right configuration, so that the flag will be enabled with the next renderers sync for 0.75?
2. Will we be able to remove the corresponding gk for it after this PR lands and we sync renderers for Native?

[rickhanlonii]

🎉

[hoxyq]

Looks like this flag was enabled for OSS renderers, and we still rely on gk for internal one.

Then I would change the approach, we can gradually roll out the internal gk, and then move the flag from the list of dynamic ones to the static, with a default value of true. Then we can remove the gk and everything else related.

cc @yungsters Is my thinking correct?

[yungsters]

Then I would change the approach, we can gradually roll out the internal gk, and then move the flag from the list of dynamic ones to the static, with a default value of true. Then we can remove the gk and everything else related.

Yes, that is correct. Thanks, @hoxyq.