Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge Environment Name on Thrown Errors from the Server #29846

Merged
merged 10 commits into from
Jun 26, 2024
Merged

Badge Environment Name on Thrown Errors from the Server #29846

merged 10 commits into from
Jun 26, 2024

Commits on Jun 26, 2024

  1. Encode the environmentName that thrown errors came from 

    This is attached to our custom Error "sub class" on the receiving side
which also includes digest.

DEV-only.
    @sebmarkbage
    sebmarkbage committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    afe92ea View commit details
    Browse the repository at this point in the history

  2. Generalize ReactFlightClientConsoleConfig to Fiber Clients too

    @sebmarkbage
    sebmarkbage committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    153e78b View commit details
    Browse the repository at this point in the history

  3. Log error/warn to our consoleWithStackDev 

    This way this helper can use component stacks when available.
    @sebmarkbage
    sebmarkbage committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9ecc408 View commit details
    Browse the repository at this point in the history

  4. Add Environment Badge in defaultOnCaughtError Logging 

    That way your typical log of an error that originated on the Server gets
a `[Server]` badge.

Unfortunately because defaultOnUncaughtError and defaultOnRecoverableError
doesn't use custom logging but goes through reportError. There's no place
for us to add this kind of formatted badging to the logs.

It's also unfortunate that you'd have to replicate this in user space.
    @sebmarkbage
    sebmarkbage committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    12ccf6f View commit details
    Browse the repository at this point in the history

  5. Same thing in Fizz

    @sebmarkbage
    sebmarkbage committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ff2b77f View commit details
    Browse the repository at this point in the history

  6. Ignore error

    @sebmarkbage
    sebmarkbage committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    11c4047 View commit details
    Browse the repository at this point in the history

  7. Allow arg mismatches

    @sebmarkbage
    sebmarkbage committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    016d86b View commit details
    Browse the repository at this point in the history

  8. Align shouldIgnoreConsole opt-out

    @sebmarkbage
    sebmarkbage committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    fcc2fa6 View commit details
    Browse the repository at this point in the history

  9. Fix env name

    @sebmarkbage
    sebmarkbage committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    763ae0a View commit details
    Browse the repository at this point in the history

  10. Fix lint

    @sebmarkbage
    sebmarkbage committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d31e852 View commit details
    Browse the repository at this point in the history