-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add react-easy-state to list of known incompatible libraries. #29661
Conversation
Like mobx, this library depends on mutating a Proxied store and breaks reference equality checks.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comparing: c2b45ef...8abd3c2 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I double-checked the library (https://github.com/RisingStack/react-easy-state) and confirmed that it's incompatible for the same reasons as mobx. Both libraries break when using useMemo()
because they rely on interior mutability and their own change propagation mechanisms.
Like mobx, this library depends on mutating a Proxied store and breaks reference equality checks. DiffTrain build for commit aa3d6c0.
Like mobx, this library depends on mutating a Proxied store and breaks reference equality checks. My workplace uses this library and I'd love for it to show as incompatible. Thank you!
Summary
How did you test this change?