Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-easy-state to list of known incompatible libraries. #29661

Merged
merged 2 commits into from
May 30, 2024

Conversation

joshwilsonvu
Copy link
Contributor

Like mobx, this library depends on mutating a Proxied store and breaks reference equality checks. My workplace uses this library and I'd love for it to show as incompatible. Thank you!

Summary

How did you test this change?

Like mobx, this library depends on mutating a Proxied store and breaks reference equality checks.
Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 2:49pm

@react-sizebot
Copy link

react-sizebot commented May 29, 2024

Comparing: c2b45ef...8abd3c2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 496.38 kB 496.38 kB = 88.84 kB 88.84 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.11% 1.82 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 501.20 kB 501.20 kB = 89.53 kB 89.53 kB
facebook-www/ReactDOM-prod.classic.js = 593.81 kB 593.81 kB = 104.45 kB 104.45 kB
facebook-www/ReactDOM-prod.modern.js = 570.20 kB 570.20 kB = 100.85 kB 100.85 kB
test_utils/ReactAllWarnings.js Deleted 63.65 kB 0.00 kB Deleted 15.90 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 63.65 kB 0.00 kB Deleted 15.90 kB 0.00 kB

Generated by 🚫 dangerJS against 8abd3c2

Copy link
Contributor

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I double-checked the library (https://github.com/RisingStack/react-easy-state) and confirmed that it's incompatible for the same reasons as mobx. Both libraries break when using useMemo() because they rely on interior mutability and their own change propagation mechanisms.

@josephsavona josephsavona merged commit aa3d6c0 into facebook:main May 30, 2024
51 checks passed
github-actions bot pushed a commit that referenced this pull request May 30, 2024
Like mobx, this library depends on mutating a Proxied store and breaks reference equality checks.

DiffTrain build for commit aa3d6c0.
github-actions bot pushed a commit that referenced this pull request May 30, 2024
Like mobx, this library depends on mutating a Proxied store and breaks reference equality checks.

DiffTrain build for [aa3d6c0](aa3d6c0)
@joshwilsonvu joshwilsonvu deleted the patch-1 branch June 3, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants