Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Run prettier #29214

Merged
merged 10 commits into from
May 29, 2024
Merged

[compiler] Run prettier #29214

merged 10 commits into from
May 29, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented May 22, 2024

[ghstack-poisoned]
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 2:44am

@react-sizebot
Copy link

react-sizebot commented May 22, 2024

Comparing: a9a0106...06536c1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 496.38 kB 496.38 kB = 88.84 kB 88.84 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 501.20 kB 501.20 kB = 89.53 kB 89.53 kB
facebook-www/ReactDOM-prod.classic.js = 593.81 kB 593.81 kB = 104.45 kB 104.45 kB
facebook-www/ReactDOM-prod.modern.js = 570.20 kB 570.20 kB = 100.85 kB 100.85 kB
test_utils/ReactAllWarnings.js Deleted 63.65 kB 0.00 kB Deleted 15.90 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 63.65 kB 0.00 kB Deleted 15.90 kB 0.00 kB

Generated by 🚫 dangerJS against 06536c1

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Copy link

@Zaid-maker Zaid-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a condition when the prettier runs on a PR in the future and if there is change then commit it with new changes.

It can be achieved with following:

- name: Commit Chagnes
  run: |
     git add .
     git commit -m 'prettier changes'
     git push

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@poteto poteto merged commit 06536c1 into gh/poteto/12/base May 29, 2024
35 of 50 checks passed
poteto added a commit that referenced this pull request May 29, 2024
After this is merged, I'll add it to .git-blame-ignore-revs. I can't do
it now as the hash will change after ghstack lands this stack.

ghstack-source-id: 054ca869b7839c589524c47d1962262f6b50f8ed
Pull Request resolved: #29214
@poteto poteto deleted the gh/poteto/12/head branch May 29, 2024 02:46
lakshmiji-jio pushed a commit to lakshmiji-jio/lakshmiji-react that referenced this pull request Jun 1, 2024
This commit will be ignored in .git-blame-ignore-revs

ghstack-source-id: ac728261488a49034dd2b8f23d4b58fd23c87f46
Pull Request resolved: facebook/react#29214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants