Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using Scheduler.log to test double invocations #29008

Merged
merged 2 commits into from
May 20, 2024
Merged

Stop using Scheduler.log to test double invocations #29008

merged 2 commits into from
May 20, 2024

Commits on May 20, 2024

  1. Stop using Scheduler.log to test double invocations 

    We don't do this to test double render invocations either since we ignore Scheduler.log for the second render.
The plan is to do the same for double invoking effects to reduce test noise.
    @eps1lon
    eps1lon committed May 20, 2024
    Configuration menu
    Copy the full SHA
    17e94fe View commit details
    Browse the repository at this point in the history

  2. Keep log assertions small 

    The longer the list of log lines asserted one, the harder future diffs are to comprehend.
git-diff produces hard to decipher diffs if the StrictEffects behavior is changed slightly that results in more lines added.
It won't be obvious anymore which lines were added and which ones were removed.
    @eps1lon
    eps1lon committed May 20, 2024
    Configuration menu
    Copy the full SHA
    686bed8 View commit details
    Browse the repository at this point in the history