Delete use of source in JSX runtime
#28433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
force-pushed
the
delete-use-of-source-in-jsx
branch
from
405ba4b
to
f343031
Compare
facebook-github-bot
added
the
React Core Team
acdlite
commented
Feb 23, 2024
| } else { | ||
| info += getDeclarationErrorAddendum(); | ||
| } | ||
| info += getDeclarationErrorAddendum(); |
There was a problem hiding this comment.
@sebmarkbage I assume I can delete this too? All it does is print "Check the render method of " which is some 2017 bullshit anyway.
There was a problem hiding this comment.
Yea in this case you have the full stack trace.
In the key warning it’s nice to have the owner of the child rather than the parent where the warning happens.
There was a problem hiding this comment.
anticipated my next question :) Thanks
|
Comparing: 47beb96...3018f45 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show |
sebmarkbage
approved these changes
Feb 23, 2024
Only remaining place it was being used was in a warning message.
acdlite
force-pushed
the
delete-use-of-source-in-jsx
branch
from
f343031
to
3018f45
Compare
huozhi
added a commit
to vercel/next.js
that referenced
this pull request
Feb 26, 2024
### React upstream changes - facebook/react#28438 - facebook/react#28436 - facebook/react#25954 - facebook/react#28434 - facebook/react#28433 - facebook/react#28432 - facebook/react#28415 - facebook/react#27903 - facebook/react#28430 - facebook/react#28424 - facebook/react#28400 - facebook/react#28422 - facebook/react#28423 - facebook/react#28412 - facebook/react#28418 - facebook/react#28421 - facebook/react#28417 - facebook/react#28399 - facebook/react#28408 - facebook/react#28350 - facebook/react#28387 - facebook/react#28403 - facebook/react#28384 - facebook/react#28409 - facebook/react#28398 - facebook/react#28405 - facebook/react#28328 - facebook/react#28402 - facebook/react#28386 - facebook/react#28388 - facebook/react#28379 - facebook/react#28383 - facebook/react#28390 - facebook/react#28389 - facebook/react#28382 - facebook/react#28348 Closes NEXT-2600
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Only remaining place it was being used was in a warning message.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
Only remaining place it was being used was in a warning message. DiffTrain build for commit 16d3f78.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only remaining place it was being used was in a warning message.