Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: select console error to not suggest to set readonly to true #27740

Merged
merged 4 commits into from
Dec 1, 2023
Merged

fix: select console error to not suggest to set readonly to true #27740

merged 4 commits into from
Dec 1, 2023

Conversation

Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Nov 22, 2023 •
edited
Loading

fix #27657

added test in the ReactDOMSELECT-test.js to not allow regession to happen in future.

After changes this is what the error message looks like

Screen.Recording.2023-11-22.at.9.37.13.PM.mov

@Biki-das
Copy link
Contributor Author

Biki-das commented Nov 22, 2023 •
edited
Loading

cc @hoxyq @sophiebits tried my best to fix this, 😅 waiting for you all to review and your thoughts, i have tried to add some more tests , guess that is not bad since it just ensures these components are less prone to bugs in future.

@react-sizebot
Copy link

react-sizebot commented Nov 22, 2023 •
edited
Loading

Comparing: bbb9cb1...1a6b6b5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 175.90 kB 175.90 kB = 54.75 kB 54.75 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.97 kB 177.97 kB = 55.39 kB 55.39 kB
facebook-www/ReactDOM-prod.classic.js = 569.81 kB 569.81 kB = 100.29 kB 100.29 kB
facebook-www/ReactDOM-prod.modern.js = 553.67 kB 553.67 kB = 97.38 kB 97.38 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 1a6b6b5

@Biki-das
Copy link
Contributor Author

@hoxyq friendly ping :-)

@Biki-das Biki-das requested a review from hoxyq November 29, 2023 14:02
@Biki-das
Copy link
Contributor Author

Biki-das commented Dec 1, 2023

@hoxyq pushed a new commit, added an expect statement to check to .not.toThrow(), tests are passing as of now.

@hoxyq
Copy link
Contributor

hoxyq commented Dec 1, 2023

@hoxyq pushed a new commit, added an expect statement to check to .not.toThrow(), tests are passing as of now.

Thanks, I think you've missed the first case.

@Biki-das
Copy link
Contributor Author

Biki-das commented Dec 1, 2023

@hoxyq thanks for catching that and assisting in this one :-) , added the same.

@Biki-das
Copy link
Contributor Author

Biki-das commented Dec 1, 2023

@hoxyq done ✅.

@hoxyq hoxyq merged commit 5dd3596 into facebook:main Dec 1, 2023
36 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 1, 2023
@hoxyq
fix: select console error to not suggest to set readonly to true (#27740
c35082f 
)

fix #27657

added test in the `ReactDOMSELECT-test.js` to not allow regession to
happen in future.

After changes this is what the error message looks like

https://github.com/facebook/react/assets/72331432/53dcbe2a-70d2-43d2-a52d-a4fc389fdfbf

DiffTrain build for [5dd3596](5dd3596)
@Biki-das Biki-das mentioned this pull request Dec 5, 2023
Merged
hoxyq pushed a commit that referenced this pull request Dec 8, 2023
@Biki-das
feat:-added tests for more coverage in reactDom-input and reactText-a…
a3aae7f 
…rea (#27796)

Small test similar to few tests added in #27740 , the `reactDom-input`
error message was just modified to match the error message, and the
`reactDomTextarea-test.js` has tests added to ensure more coverage.
@ztanner ztanner mentioned this pull request Dec 15, 2023
Merged
ztanner added a commit to vercel/next.js that referenced this pull request Dec 15, 2023
@ztanner
Update React from 2c338b16f to 0cdfef19b (#59666)
1fa7a74 
Updates React from 2c338b16f to 0cdfef19b.

### React upstream changes

- facebook/react#27821
- facebook/react#27820
- facebook/react#27818
- facebook/react#27819
- facebook/react#27817
- facebook/react#27703
- facebook/react#27796
- facebook/react#27811
- facebook/react#27804
- facebook/react#27807
- facebook/react#27805
- facebook/react#27792
- facebook/react#27788
- facebook/react#26852
- facebook/react#27790
- facebook/react#27786
- facebook/react#27785
- facebook/react#27783
- facebook/react#27784
- facebook/react#27769
- facebook/react#27766
- facebook/react#27701
- facebook/react#27732
- facebook/react#27740
- facebook/react#27767
- facebook/react#27768
- facebook/react#27765
- facebook/react#27759
- facebook/react#27579
- facebook/react#27709
- facebook/react#27734
- facebook/react#27739
- facebook/react#27717
- facebook/react#27583
- facebook/react#27713

Closes NEXT-1887
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
@ztanner @agustints
Update React from 2c338b16f to 0cdfef19b (vercel#59666)
9620d19 
Updates React from 2c338b16f to 0cdfef19b.

### React upstream changes

- facebook/react#27821
- facebook/react#27820
- facebook/react#27818
- facebook/react#27819
- facebook/react#27817
- facebook/react#27703
- facebook/react#27796
- facebook/react#27811
- facebook/react#27804
- facebook/react#27807
- facebook/react#27805
- facebook/react#27792
- facebook/react#27788
- facebook/react#26852
- facebook/react#27790
- facebook/react#27786
- facebook/react#27785
- facebook/react#27783
- facebook/react#27784
- facebook/react#27769
- facebook/react#27766
- facebook/react#27701
- facebook/react#27732
- facebook/react#27740
- facebook/react#27767
- facebook/react#27768
- facebook/react#27765
- facebook/react#27759
- facebook/react#27579
- facebook/react#27709
- facebook/react#27734
- facebook/react#27739
- facebook/react#27717
- facebook/react#27583
- facebook/react#27713

Closes NEXT-1887
@Biki-das Biki-das deleted the react-select branch February 15, 2024 15:26
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@Biki-das @AndyPengc12
fix: select console error to not suggest to set readonly to true (fac…
e2e94d9 
…ebook#27740)

fix facebook#27657 

added test in the `ReactDOMSELECT-test.js` to not allow regession to
happen in future.

After changes this is what the error message looks like


https://github.com/facebook/react/assets/72331432/53dcbe2a-70d2-43d2-a52d-a4fc389fdfbf
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@Biki-das @AndyPengc12
feat:-added tests for more coverage in reactDom-input and reactText-a…
850d4f7 
…rea (facebook#27796)

Small test similar to few tests added in facebook#27740 , the `reactDom-input`
error message was just modified to match the error message, and the
`reactDomTextarea-test.js` has tests added to ensure more coverage.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@hoxyq
fix: select console error to not suggest to set readonly to true (#27740
01d7c97 
)

fix #27657

added test in the `ReactDOMSELECT-test.js` to not allow regession to
happen in future.

After changes this is what the error message looks like

https://github.com/facebook/react/assets/72331432/53dcbe2a-70d2-43d2-a52d-a4fc389fdfbf

DiffTrain build for commit 5dd3596.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weikhor weikhor weikhor left review comments

@hoxyq hoxyq hoxyq approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Select when passed a value as Prop errors with a suggestion to pass readOnly
5 participants
@Biki-das @react-sizebot @hoxyq @weikhor @facebook-github-bot