[Fizz] Simplify ReplayNode data structure #27395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simpler and more compact format because we don't have to separate the three Resume forms.
This lets us share logic between resume/replaySuspenseBoundary.
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
commented
Sep 20, 2023
| string | null /* name */, | ||
| string | number /* key */, | ||
| Array<ResumableNode> /* children */, | ||
| Array<ReplayNode> /* keyed children */, |
There was a problem hiding this comment.
Instead of storing the key on the node we could also turn this into two keyed objects. One of number keys and one for string keys.
acdlite
approved these changes
Sep 20, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 21, 2023
The key is that instead of storing different tags of resumable points, we just store if a replay node has any resumable slots and if that's at the root `number` or if it has resumable slots by index. This is a simpler and more compact format because we don't have to separate the three Resume forms. This helps deal with Postpone in fallbacks because it doesn't just double all the cases. DiffTrain build for [47fed69](47fed69)
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Sep 26, 2023
### React upstream changes - facebook/react#27417 - facebook/react#27408 - facebook/react#27409 - facebook/react#27405 - facebook/react#27375 - facebook/react#27407 - facebook/react#27365 - facebook/react#27399 - facebook/react#27395 - facebook/react#27394 - facebook/react#27397 - facebook/react#26992 - facebook/react#27388 - facebook/react#27373 - facebook/react#27332
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
The key is that instead of storing different tags of resumable points, we just store if a replay node has any resumable slots and if that's at the root `number` or if it has resumable slots by index. This is a simpler and more compact format because we don't have to separate the three Resume forms. This helps deal with Postpone in fallbacks because it doesn't just double all the cases.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
The key is that instead of storing different tags of resumable points, we just store if a replay node has any resumable slots and if that's at the root `number` or if it has resumable slots by index. This is a simpler and more compact format because we don't have to separate the three Resume forms. This helps deal with Postpone in fallbacks because it doesn't just double all the cases. DiffTrain build for commit 47fed69.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key is that instead of storing different tags of resumable points, we just store if a replay node has any resumable slots and if that's at the root
numberor if it has resumable slots by index.This is a simpler and more compact format because we don't have to separate the three Resume forms.
This helps deal with Postpone in fallbacks because it doesn't just double all the cases.