Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate DevTools test to fix CI #26742

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Gate DevTools test to fix CI #26742

merged 1 commit into from
Apr 29, 2023

Commits on Apr 29, 2023

  1. Gate DevTools test to fix CI

    This test started failing recently in older versions of React because
    the Scheduler priority inside a microtask is Normal instead of
    Immediate. This is expected because microtasks are not Scheduler tasks;
    it's an implementation detail.
    
    I gated the test to only run in v17 because it's a regression test for
    legacy Suspense behavior, and the implementation details of the snapshot
    changed in v18.
    
    Test plan
    ---------
    
    Using latest:
    
    ```
    yarn test --build --project devtools --release-channel=experimental profilingcache
    ```
    
    Using v17 (typically runs in a timed CI workflow):
    
    ```
    /scripts/circleci/download_devtools_regression_build.js 17.0 --replaceBuild
    yarn test --build --project devtools --release-channel=experimental --reactVersion 17.0 profilingcache
    ```
    acdlite committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    79793dd View commit details
    Browse the repository at this point in the history