Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove revertRemovalOfSiblingPrerendering killswitch #26549

Conversation

sammy-SC
Copy link
Contributor

@sammy-SC sammy-SC commented Apr 4, 2023

removal of sibling prerendering has been rolled out at Meta. We can delete the flag now.

@sammy-SC sammy-SC marked this pull request as draft April 4, 2023 13:38
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Apr 4, 2023
@react-sizebot
Copy link

react-sizebot commented Apr 4, 2023

Comparing: 5426af3...18a96dc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.40 kB 164.40 kB = 51.65 kB 51.65 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 166.84 kB 166.84 kB = 52.30 kB 52.30 kB
facebook-www/ReactDOM-prod.classic.js = 565.32 kB 564.98 kB = 99.49 kB 99.39 kB
facebook-www/ReactDOM-prod.modern.js = 549.11 kB 548.77 kB = 96.79 kB 96.69 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 18a96dc

@sammy-SC sammy-SC force-pushed the sammy/remove-feature-flag-revertRemovalOfSiblingPrerendering branch 2 times, most recently from b1eb8cd to b1657f1 Compare April 4, 2023 13:53
@sammy-SC sammy-SC marked this pull request as ready for review April 5, 2023 08:50
@sammy-SC sammy-SC force-pushed the sammy/remove-feature-flag-revertRemovalOfSiblingPrerendering branch from 9cb3f86 to 18a96dc Compare April 12, 2023 12:40
@acdlite acdlite merged commit 7b0642b into facebook:main Apr 13, 2023
github-actions bot pushed a commit that referenced this pull request Apr 13, 2023
removal of sibling prerendering has been rolled out at Meta. We can
delete the flag now.

DiffTrain build for [7b0642b](7b0642b)
@sammy-SC sammy-SC deleted the sammy/remove-feature-flag-revertRemovalOfSiblingPrerendering branch April 14, 2023 15:55
kassens added a commit to kassens/react that referenced this pull request Apr 17, 2023
kassens pushed a commit that referenced this pull request Apr 21, 2023
removal of sibling prerendering has been rolled out at Meta. We can
delete the flag now.
tyao1 added a commit that referenced this pull request Feb 7, 2024
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
removal of sibling prerendering has been rolled out at Meta. We can
delete the flag now.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
removal of sibling prerendering has been rolled out at Meta. We can
delete the flag now.

DiffTrain build for commit 7b0642b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants