Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix devtools tests after internal test changes #26405

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Fix devtools tests after internal test changes #26405

merged 1 commit into from
Mar 16, 2023
+18 −13

Conversation

rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Mar 16, 2023 •
edited
Loading

Overview

  • In older React versions (16, 17), there's no need to use act. So if it's not available, don't use it.
  • TimelineProfiler tests need to use internal act. But if we patch in an old version of the scheduler (v18.0-18.2) then the scheduler mock wont work with the internal test harness. We could support all versions of the scheduler in the internal helpers, but it's probably fine to just bump the version of React supported to 18.3 since there weren't many related changes in 18.0-18.2.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 16, 2023
@rickhanlonii rickhanlonii merged commit 9941cba into facebook:main Mar 16, 2023
@rickhanlonii rickhanlonii deleted the rh/fix-devtool-tests branch March 16, 2023 12:14
@sammy-SC sammy-SC mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickhanlonii @acdlite @facebook-github-bot