Copy from build to node_modules instead of linking to builds #26210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: c8d4eed...53f7c6b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
force-pushed
the
fixfixtures
branch
from
974c033
to
d99c7d6
Compare
acdlite
approved these changes
Feb 21, 2023
sebmarkbage
force-pushed
the
fixfixtures
branch
from
d99c7d6
to
53f7c6b
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
Using the `link:` protocol to create a dependency doesn't work when we edit the `package.json` to lock the version to a specific version. It didn't really work before neither, it was just that `yarn` installed an existing `scheduler` dependency from npm instead of using the built one. So I'm updating all the fixture to use the technique where we copy files instead. DiffTrain build for commit 0a76fb9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
link:protocol to create a dependency doesn't work when we edit thepackage.jsonto lock the version to a specific version. It didn't really work before neither, it was just thatyarninstalled an existingschedulerdependency from npm instead of using the built one.So I'm updating all the fixture to use the technique where we copy files instead.