Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary flowconfig ignore paths #26159

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

ymqy
Copy link
Contributor

@ymqy ymqy commented Feb 12, 2023

Summary

By removing them, the flowconfig file will be cleaner and easier to maintain.

How did you test this change?

ci green

@react-sizebot
Copy link

Comparing: 64acd39...71b93e5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.54 kB 154.54 kB = 48.83 kB 48.83 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.54 kB 156.54 kB = 49.45 kB 49.45 kB
facebook-www/ReactDOM-prod.classic.js = 529.73 kB 529.73 kB = 94.36 kB 94.36 kB
facebook-www/ReactDOM-prod.modern.js = 514.95 kB 514.95 kB = 92.17 kB 92.17 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 71b93e5

@kassens
Copy link
Member

kassens commented Feb 12, 2023

Nice.

@kassens kassens merged commit 4a4ef27 into facebook:main Feb 12, 2023
github-actions bot pushed a commit that referenced this pull request Feb 12, 2023
## Summary

By removing them, the flowconfig file will be cleaner and easier to
maintain.

## How did you test this change?

ci green

DiffTrain build for [4a4ef27](4a4ef27)
[View git log for this commit](https://github.com/facebook/react/commits/4a4ef2706cfb51db96d48fe20dadcb4fb8e3cb17)
@ymqy ymqy deleted the remove-unused-config branch February 13, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants