Update danger.js token #26066
Merged
Update danger.js token #26066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
kassens
force-pushed
the
sizebot-token
branch
from
0d19e8b
to
96bfb2c
Compare
|
Pipeline secrets are usually excluded from PRs from forks. We could expose Pipeline secrets to forks which would at least show use once they got leaked. Hard-coding secrets into code has the downside of not knowing when secrets get leaked. Either way, we have to pass these secrets to untrusted sources (forks). The only decision we can make is wether we're ok with accidentally leaking (hard-coding) or leaking to "malicious" actors (pipeline secrets). |
This reverts commit 5e600f0.
kassens
force-pushed
the
sizebot-token
branch
from
6e1bb69
to
4166084
Compare
|
Comparing: 0652bdb...4166084 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rickhanlonii
approved these changes
Jan 27, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
The old token was revoked, this updates the token by reading from CI secrets instead, I'm not sure there's benefit in making it publicly visible. DiffTrain build for [cb16201](cb16201) [View git log for this commit](https://github.com/facebook/react/commits/cb16201180a2642696303d4aac3a04e5fd348512)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old token was revoked, this updates the token by reading from CI secrets instead, I'm not sure there's benefit in making it publicly visible.