Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG.md Change parentheses position #25762

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Conversation

lucas0530
Copy link
Contributor

hi there!

It's a small change, but it contains my desire to make the React document a little more perfect.

Summary

Change the position of the parentheses in the document below.

  • ./CHANGELOG.md

How did you test this change?

It's just a commit to modify a few characters, but it can create a more complete react document.

@sizebot
Copy link

sizebot commented Dec 1, 2022

Comparing: f197ca9...346e462

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.55 kB 154.55 kB = 49.05 kB 49.04 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.47 kB 156.47 kB = 49.67 kB 49.67 kB
facebook-www/ReactDOM-prod.classic.js = 533.67 kB 533.67 kB = 94.54 kB 94.54 kB
facebook-www/ReactDOM-prod.modern.js = 518.77 kB 518.77 kB = 92.35 kB 92.35 kB
facebook-www/ReactDOMForked-prod.classic.js = 533.67 kB 533.67 kB = 94.54 kB 94.54 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 346e462

Copy link

@poolyumlim poolyumlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not necessary

@lucas0530
Copy link
Contributor Author

Waiting after requesting a review.

Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants