Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rollup #24890

Closed
wants to merge 1 commit into from
Closed

Update Rollup #24890

wants to merge 1 commit into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jul 12, 2022

Re-submit of #19918.

Don't know if this works yet.

@ymqy
Copy link
Contributor

ymqy commented Jan 31, 2023

@gaearon Hi, dan, I've also been working on upgrading the react dependency with rollup lately. I found that you're also doing the same thing. Since my first PR to react was merged, I feel honored and want to actively participate in open-source projects. I have encountered the same CI problems as you, and tried to find solutions and passed the test cases. However,
#26078 there are still some issues left: increased bundle size, some code not being treeshaked. Other than that, there are no obstacles. Regarding the two CI problems that didn't pass, you can update the flowconfig ignore and add a line "./node_modules/resolve/test/." to resolve the yarn_flow issue. As for the yarn_build_combined problem, it won't appear on the main branch anymore, it has been fixed in this PR #25132.

@sebmarkbage
Copy link
Collaborator

Outdated

@gaearon gaearon deleted the rollupbump branch February 14, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants