RFC: flushSync should flush passive effects if they were the result of a sync update #21124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are pending passive effects that were the result of a sync/discrete update, `flushSync()` should flush them, so the caller can observe the result. We can skip passive effects that don't have sync/discrete priority. This would replace the need for `flushDiscreteUpdates()`, which is identical to `flushSync()` except for this.
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 634cc52...12c2e0c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
bvaughn
approved these changes
Mar 29, 2021
|
Closed in favor of #21150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are pending passive effects that were the result of a sync/discrete update,
flushSync()should flush them, so the caller can observe the result.We can skip passive effects that don't have sync/discrete priority.
This would replace the need for
flushDiscreteUpdates(), which is identical toflushSync()except for this.