Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fire the render phase update warning for class lifecycles #18330

Merged
merged 3 commits into from
Mar 18, 2020
Merged

Don't fire the render phase update warning for class lifecycles #18330

merged 3 commits into from
Mar 18, 2020

Commits on Mar 17, 2020

  1. Change the warning to not say "function body" 

    This warning is more generic and may happen with class components too.
    @gaearon
    gaearon committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    537919d View commit details
    Browse the repository at this point in the history

  2. Dedupe by the rendering component

    @gaearon
    gaearon committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    959b279 View commit details
    Browse the repository at this point in the history

  3. Don't warn outside of render

    @gaearon
    gaearon committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    933157f View commit details
    Browse the repository at this point in the history