-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import React DevTools v4 #16381
Merged
Merged
Import React DevTools v4 #16381
+63,546
−243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removed from selected highlight
1. Bugfix: Hide tree grouping/background coloring when inside of collapsed subtree. 2. Bugfix: Don't measure and udpate indentation when Components tab is hidden. 3. Tweak: Lower background color for selected subtree in light theme to increase contrast for text. 4. Tweak: Remove FB-specific displayName check/hack since we will address that by modifying the internal require JS transform.
As a result, paddings and sizes (e.g. tab bar heights) will also be impacted now by this preference. More importantly, Profile charts will also use the line height preference, so the 'comfortable' setting will hopefully make profiling data easier to read.
Components tree changes to improve HOCs and browsing deep trees
…es e.g. reload-and-profile based on this.
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.12.1 to 3.13.1. - [Release notes](https://github.com/nodeca/js-yaml/releases) - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.12.1...3.13.1) Signed-off-by: dependabot[bot] <[email protected]>
…js-yaml-3.13.1 Bump js-yaml from 3.12.1 to 3.13.1
* User profiling setting * Background collects changed props/state (not added/removed or hooks yet) * Tests updated
…o include DevTools tests.
…act-dom and react-test-renderers
bvaughn
changed the title
Import React DevTools v4 [DO NOT MERGE]
Import React DevTools v4
Aug 28, 2019
🎉🎉🎉 |
This was referenced Aug 17, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports the entire React DevTools v4 git repository (with history). I will manually migrate open issues after this PR has landed.
Despite its size, this PR is almost entirely additive:
Checklist
ReactDebugHooks
fork (and usereact-debug-tools
)package.json
react-devtools
standalone appreact-devtools-core
packagereact-devtools-extensions
(Chrome and Firefox)react-devtools-inline
packagereact-devtools-shell
test harnessREADME
instructionsFolder structure
Importing
The goal of this import is to preserve history from the DevTools v4 fork. Below are the steps I followed. Afterward, I verified that
git log --follow
worked as expected on imported files.Prepare fork for merge
Import into React