Fix useImperativeHandle to have no deps by default #14801
Merged
+107
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
approved these changes
Feb 11, 2019
| @@ -905,7 +905,7 @@ function mountImperativeHandle<T>( | |||
|
|
|||
| // TODO: If deps are provided, should we skip comparing the ref itself? | |||
| const effectDeps = | |||
| deps !== null && deps !== undefined ? deps.concat([ref]) : [ref]; | |||
| deps !== null && deps !== undefined ? deps.concat([ref]) : deps; | |||
There was a problem hiding this comment.
Suggested change
| deps !== null && deps !== undefined ? deps.concat([ref]) : deps; | |
| deps !== null && deps !== undefined ? deps.concat([ref]) : null; |
Nit: Should only be null, not undefined. I wondered why this wasn't a type error but it's because mountEffectImpl and updateEffectImpl contain their own type check; we might inline those later.
| @@ -931,7 +931,7 @@ function updateImperativeHandle<T>( | |||
|
|
|||
| // TODO: If deps are provided, should we skip comparing the ref itself? | |||
| const effectDeps = | |||
| deps !== null && deps !== undefined ? deps.concat([ref]) : [ref]; | |||
| deps !== null && deps !== undefined ? deps.concat([ref]) : deps; | |||
Just checked — both are noops. |
This was referenced Aug 12, 2019
This was referenced Aug 20, 2019
This was referenced Aug 27, 2019
This was referenced Sep 20, 2019
Open
[Snyk] Upgrade react-dom from 16.5.2 to 16.9.0
maxiplux/spring-security-react-ant-design-polls-app#3
Open
This was referenced Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14782. If nothing is provided, there should be no dependencies — not
[ref]alone.