Call gDSFP with the right state in react-test-render #13030

fatfisz · 2018-06-12T19:27:35Z

facebook-github-bot · 2018-06-12T19:29:00Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot · 2018-06-12T19:57:44Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

gaearon · 2018-06-12T20:14:54Z

packages/react-test-renderer/src/__tests__/ReactShallowRenderer-test.js

@@ -915,6 +915,39 @@ describe('ReactShallowRenderer', () => {
    expect(result.props.children).toEqual(3);
  });

+  it('should call getDerivedStateFromProps with the state set by setState', () => {
+    class SimpleComponent extends React.Component {


Is this based on any existing test in other renderers? If not, can you please find an appropriate existing test and then use it as a base?

I'll look for that!

The only test I could find that is related to this was: "should not override state with stale values if prevState is spread within getDerivedStateFromProps" in react/packages/react-dom/src/__tests__/ReactComponentLifeCycle-test.js. I modified it a bit (it involved a parent and a child component, but in the case of shallow rendering this seemed to be a bit too complicated).

fatfisz · 2018-06-13T10:10:59Z

Just wondering, when will you be cutting a new release?

gaearon · 2018-06-13T11:36:06Z

Maybe later this week

193: Update dependency react to v16.4.1 r=magopian a=renovate[bot] This Pull Request updates dependency [react](https://github.com/facebook/react) from `v16.4.0` to `v16.4.1` <details> <summary>Release Notes</summary> ### [`v16.4.1`](https://github.com/facebook/react/blob/master/CHANGELOG.md#1641-June-13-2018) [Compare Source](facebook/react@v16.4.0...v16.4.1) ##### React * You can now assign `propTypes` to components returned by `React.ForwardRef`. ([@bvaughn] in [#12911](`https://github.com/facebook/react/pull/12911`)) ##### React DOM * Fix a crash when the input `type` changes from some other types to `text`. ([@spirosikmd] in [#12135](`https://github.com/facebook/react/pull/12135`)) * Fix a crash in IE11 when restoring focus to an SVG element. ([@ThaddeusJiang] in [#12996](`https://github.com/facebook/react/pull/12996`)) * Fix a range input not updating in some cases. ([@Illu] in [#12939](`https://github.com/facebook/react/pull/12939`)) * Fix input validation triggering unnecessarily in Firefox. ([@nhunzaker] in [#12925](`https://github.com/facebook/react/pull/12925`)) * Fix an incorrect `event.target` value for the `onChange` event in IE9. ([@nhunzaker] in [#12976](`https://github.com/facebook/react/pull/12976`)) * Fix a false positive error when returning an empty `<React.Fragment />` from a component. ([@philipp-spiess] in [#12966](`https://github.com/facebook/react/pull/12966`)) ##### React DOM Server * Fix an incorrect value being provided by new context API. ([@ericsoderberghp] in [#12985](`https://github.com/facebook/react/pull/12985`), [@gaearon] in [#13019](`https://github.com/facebook/react/pull/13019`)) ##### React Test Renderer * Allow multiple root children in test renderer traversal API. ([@gaearon] in [#13017](`https://github.com/facebook/react/pull/13017`)) * Fix `getDerivedStateFromProps()` in the shallow renderer to not discard the pending state. ([@fatfisz] in [#13030](`https://github.com/facebook/react/pull/13030`)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <[email protected]>

25: Update react monorepo to v16.4.1 r=renovate[bot] a=renovate[bot] This Pull Request renovates the package group "react monorepo". - [react-dom](https://github.com/facebook/react) (`dependencies`): from `16.4.0` to `16.4.1` - [react](https://github.com/facebook/react) (`dependencies`): from `16.4.0` to `16.4.1` # Release Notes <details> <summary>facebook/react</summary> ### [`v16.4.1`](https://github.com/facebook/react/blob/master/CHANGELOG.md#1641-June-13-2018) [Compare Source](facebook/react@v16.4.0...v16.4.1) ##### React * You can now assign `propTypes` to components returned by `React.ForwardRef`. ([@bvaughn] in [#12911](`https://github.com/facebook/react/pull/12911`)) ##### React DOM * Fix a crash when the input `type` changes from some other types to `text`. ([@spirosikmd] in [#12135](`https://github.com/facebook/react/pull/12135`)) * Fix a crash in IE11 when restoring focus to an SVG element. ([@ThaddeusJiang] in [#12996](`https://github.com/facebook/react/pull/12996`)) * Fix a range input not updating in some cases. ([@Illu] in [#12939](`https://github.com/facebook/react/pull/12939`)) * Fix input validation triggering unnecessarily in Firefox. ([@nhunzaker] in [#12925](`https://github.com/facebook/react/pull/12925`)) * Fix an incorrect `event.target` value for the `onChange` event in IE9. ([@nhunzaker] in [#12976](`https://github.com/facebook/react/pull/12976`)) * Fix a false positive error when returning an empty `<React.Fragment />` from a component. ([@philipp-spiess] in [#12966](`https://github.com/facebook/react/pull/12966`)) ##### React DOM Server * Fix an incorrect value being provided by new context API. ([@ericsoderberghp] in [#12985](`https://github.com/facebook/react/pull/12985`), [@gaearon] in [#13019](`https://github.com/facebook/react/pull/13019`)) ##### React Test Renderer * Allow multiple root children in test renderer traversal API. ([@gaearon] in [#13017](`https://github.com/facebook/react/pull/13017`)) * Fix `getDerivedStateFromProps()` in the shallow renderer to not discard the pending state. ([@fatfisz] in [#13030](`https://github.com/facebook/react/pull/13030`)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <[email protected]>

kamronbatman · 2018-06-15T01:02:05Z

@gaearon, please cut a new version asap ❤️.

gaearon · 2018-06-15T01:18:59Z

It was included in 16.4.1.

kamronbatman · 2018-06-15T02:17:28Z

@gaearon, I am still having a similar issue. It might be due to a different reason then (I am not sure at this time).
Thank you!

gaearon · 2018-06-16T01:05:51Z

Can you file a bug with reproducing case please?

gaearon · 2018-06-16T01:06:58Z

Or maybe you're getting confused about which behavior is intended?
There was a bug in 16.3 which you might accidentally have relied on.

See:

https://reactjs.org/blog/2018/05/23/react-v-16-4.html#bugfix-for-getderivedstatefromprops

and

https://reactjs.org/blog/2018/06/07/you-probably-dont-need-derived-state.html

* Call gDSFP with the right state in react-test-render * Change the test

Call gDSFP with the right state in react-test-render

fdee5c7

facebook-github-bot added the CLA Signed label Jun 12, 2018

gaearon reviewed Jun 12, 2018

View reviewed changes

Change the test

98821db

gaearon approved these changes Jun 12, 2018

View reviewed changes

gaearon merged commit 945fc1b into facebook:master Jun 12, 2018

fatfisz deleted the fix-react-test-renderer-with-setState-and-gDSFP branch June 13, 2018 10:10

This was referenced Jun 17, 2018

Update 5 dependencies from npm JetBrains/ring-ui#289

Closed

Update 6 dependencies from npm JetBrains/ring-ui#290

Merged

dependencies bot mentioned this pull request Oct 1, 2018

Update react-dom in /modules/frontend from 16.3.0 to 16.5.2 project-accelerate/accelerate#277

Open

This was referenced Nov 1, 2018

Update react-dom in / from 16.2.0 to 16.6.0 leonardofaria/leozera-ui#253

Closed

Update react in / from 16.2.0 to 16.6.0 leonardofaria/leozera-ui#254

Closed

This was referenced Dec 1, 2018

Update react-test-renderer in /modules/frontend from 16.3.0 to 16.6.3 project-accelerate/accelerate#312

Open

Update react in /modules/frontend from 16.3.0 to 16.6.3 project-accelerate/accelerate#313

Open

NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020

Call gDSFP with the right state in react-test-render (#13030)

9e0c6fd

* Call gDSFP with the right state in react-test-render * Change the test

This was referenced Mar 15, 2021

chore(deps): bump react-dom from 16.4.0 to 16.4.2 in /intro-react-v5 samuelsilvadev/front-end-master-courses#9

Merged

Bump react-dom from 16.4.0 to 16.4.2 in /client cdhenry/pivot#1

Open

This was referenced Sep 5, 2024

[Snyk] Fix for 104 vulnerabilities Omrisnyk/lock-walker#65

Open

[Snyk] Fix for 104 vulnerabilities Omrisnyk/lock-walker#66

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Call gDSFP with the right state in react-test-render #13030

Call gDSFP with the right state in react-test-render #13030

fatfisz commented Jun 12, 2018

facebook-github-bot commented Jun 12, 2018

facebook-github-bot commented Jun 12, 2018

gaearon Jun 12, 2018

fatfisz Jun 12, 2018

fatfisz Jun 12, 2018 •

edited

Loading

fatfisz commented Jun 13, 2018

gaearon commented Jun 13, 2018

kamronbatman commented Jun 15, 2018 •

edited

Loading

gaearon commented Jun 15, 2018

kamronbatman commented Jun 15, 2018

gaearon commented Jun 16, 2018

gaearon commented Jun 16, 2018

Call gDSFP with the right state in react-test-render #13030

Call gDSFP with the right state in react-test-render #13030

Conversation

fatfisz commented Jun 12, 2018

facebook-github-bot commented Jun 12, 2018

facebook-github-bot commented Jun 12, 2018

gaearon Jun 12, 2018

Choose a reason for hiding this comment

fatfisz Jun 12, 2018

Choose a reason for hiding this comment

fatfisz Jun 12, 2018 • edited Loading

Choose a reason for hiding this comment

fatfisz commented Jun 13, 2018

gaearon commented Jun 13, 2018

kamronbatman commented Jun 15, 2018 • edited Loading

gaearon commented Jun 15, 2018

kamronbatman commented Jun 15, 2018

gaearon commented Jun 16, 2018

gaearon commented Jun 16, 2018

fatfisz Jun 12, 2018 •

edited

Loading

kamronbatman commented Jun 15, 2018 •

edited

Loading