Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt into unsafe lifecycle warnings without async tree #12083

Merged
merged 13 commits into from
Jan 25, 2018
Merged

Opt into unsafe lifecycle warnings without async tree #12083

merged 13 commits into from
Jan 25, 2018

Commits on Jan 25, 2018

  1. New PreAsyncComponent warns about unsafe lifecycles in tree 

    Works like AsyncComponent except that it does not actually enable async rendering. This component is exposed via React.unstable_PreAsyncComponent (following precedent).

I also tidied up ReactBaseClass a little because the duplication was bothering me. I will revert this if there's any concern.

This branch is stacked on top of 12046-part-2 and PR facebook#12060
    @bvaughn
    bvaughn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    2b373cb View commit details
    Browse the repository at this point in the history

  2. Reverted ReactBassClass abstraction. Renamed PreAsyncComponent

    @bvaughn
    bvaughn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    1ce11f0 View commit details
    Browse the repository at this point in the history

  3. Renamed context type flag

    @bvaughn
    bvaughn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    0380b50 View commit details
    Browse the repository at this point in the history

  4. Introduced StrictMode component 

    Replace previous EnableFutureCompatibilityChecks with a new StrictMode component.

Rename the FutureCompatibilityChecks flag with a StrictMode flag.

Update Async warnings to be based on StrictMode flag instead.
    @bvaughn
    bvaughn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    a98a09a View commit details
    Browse the repository at this point in the history

  5. Renamed ReactDebugAsyncWarnings.js to ReactStrictModeWarnings.js

    @bvaughn
    bvaughn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    c0f4e7f View commit details
    Browse the repository at this point in the history

  6. Find-and-replace ReactDebugAsyncWarnings with ReactStrictModeWarnings

    @bvaughn
    bvaughn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    67aec16 View commit details
    Browse the repository at this point in the history

  7. Updated strict-mode fb.me link (and tests)

    @bvaughn
    bvaughn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    f225b46 View commit details
    Browse the repository at this point in the history

  8. Renamed ReactAsyncClassComponent-test.internal to ReactStrictMode-tes… 

    …t.internal
    @bvaughn
    bvaughn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    86cb020 View commit details
    Browse the repository at this point in the history

  9. Renamed test name

    @bvaughn
    bvaughn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    747065b View commit details
    Browse the repository at this point in the history

  10. Converted StrictMode from a class component to a symbol

    @bvaughn
    bvaughn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    a0d0551 View commit details
    Browse the repository at this point in the history

  11. Added tests for switching between Fragments/SwitchMode symbols

    @bvaughn
    bvaughn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    4a46a30 View commit details
    Browse the repository at this point in the history

  12. EActually eported and used STRICT_MODE symboll. Whoops.

    @bvaughn
    bvaughn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    be6f370 View commit details
    Browse the repository at this point in the history

  13. Introduced new type-of-work: Mode 

    Reverted some of the previous Fragment changes in favor of this approach.
    @bvaughn
    bvaughn committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    aef6692 View commit details
    Browse the repository at this point in the history