Add experimental react-call-return package #11364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
approved these changes
Oct 25, 2017
This was referenced Oct 25, 2017
|
Fwiw. I'm 100% sure we want to add another API which may replace this. I also think the current one has bugs. So very experimental and will definitely potentially break in minors so lock your deps if you want to use this. |
|
Added a disclaimer. 396eb86 |
This was referenced Nov 9, 2017
Update react in packages/oc-template-react from 16.0.0 to 16.1.0
opencomponents/oc-template-react#48
Closed
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
This was referenced Feb 2, 2018
Open
This was referenced Dec 30, 2023
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with @sebmarkbage and @thejameskyle.
This lets people experiment with Call/Return API without us committing to supporting it.
I renamed Coroutines/Yield to Call/Return because it seems like a much more straightforward metaphor. Also updated all callsites.
This lets us get rid of a few "bad" internal imports too.