Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hyperlink tag with button tag in tic-tac-toe tutorial and update related references in the tutorial document #11045

Merged
merged 2 commits into from
Oct 3, 2017

Conversation

pyitphyoaung
Copy link
Contributor

…ate related references in the tutorial document

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Format your code with prettier (npm run prettier).
  6. Make sure your code lints (npm run lint).
  7. Run the Flow typechecks (npm run flow).
  8. If you haven't already, complete the CLA.

…ate related references in the tutorial document
@reactjs-bot
Copy link

reactjs-bot commented Oct 2, 2017

Deploy preview ready!

Built with commit 3c0133d

https://deploy-preview-11045--reactjs.netlify.com

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! 😄

@bvaughn bvaughn merged commit 85b59d2 into facebook:master Oct 3, 2017
@gaearon
Copy link
Collaborator

gaearon commented Oct 3, 2017

@bvaughn We'll need to update all codepens now, right?

@gaearon
Copy link
Collaborator

gaearon commented Oct 3, 2017

These look confusing as buttons:

screen shot 2017-10-03 at 5 01 22 pm

We should also update their labels. For example

etc

@gaearon
Copy link
Collaborator

gaearon commented Oct 3, 2017

I'll do that.

@gaearon
Copy link
Collaborator

gaearon commented Oct 3, 2017

Done. :-)

@bvaughn
Copy link
Contributor

bvaughn commented Oct 3, 2017

@bvaughn
Copy link
Contributor

bvaughn commented Oct 3, 2017

You rock! 🎸

@pyitphyoaung
Copy link
Contributor Author

Yay! Cheers, guys! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants