Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createReactClassIntegration-test fails #9997

Closed
vritant24 opened this issue Jun 18, 2017 · 2 comments
Closed

createReactClassIntegration-test fails #9997

vritant24 opened this issue Jun 18, 2017 · 2 comments
Assignees

Comments

@vritant24
Copy link

Do you want to request a feature or report a bug?
bug

What is the current behavior?
on running npm test on master branch, createReactClassIntegration-test fails

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/84v837e9/).
I just installed the repo after cloning it, ran npm install, and then npm test.

What is the expected behavior?
Test should pass

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
Latest version as of commit 00ba97a

@gaearon
Copy link
Collaborator

gaearon commented Jun 19, 2017

It probably fails because you run npm install rather than yarn so you get the latest version (which included a bugfix). We need to cherrypick an equivalent of 07fe7ad and 76b916b to master I think.

@gaearon gaearon self-assigned this Jun 19, 2017
@gaearon
Copy link
Collaborator

gaearon commented Jun 21, 2017

This should be fixed by #9629.

@gaearon gaearon closed this as completed Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants