Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onClick and onChange doesn't fire on radio buttons on iOS #9956

Closed
badtant opened this issue Jun 14, 2017 · 16 comments
Closed

onClick and onChange doesn't fire on radio buttons on iOS #9956

badtant opened this issue Jun 14, 2017 · 16 comments

Comments

@badtant
Copy link

badtant commented Jun 14, 2017

Do you want to request a feature or report a bug?
bug

What is the current behavior?
onClick and onChange doesn't fire on radio buttons on iOS
TypeError: undefined is not an object (evaluating 'descriptor.get.call')

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/84v837e9/).

<input type="radio" name="vote" value="0" onChange={this._sendVote} />
<input type="radio" name="vote" value="1" onChange={this._sendVote} />

What is the expected behavior?
onClick and onChange should fire

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React 15.6.0 on iOS. Was working on 15.5.4

@gaearon
Copy link
Collaborator

gaearon commented Jun 14, 2017

cc @aweary @nhunzaker

@gaearon
Copy link
Collaborator

gaearon commented Jun 14, 2017

also cc @jquense, this code was added in #8575.

@jquense
Copy link
Contributor

jquense commented Jun 14, 2017

o my there should have been a fix in with this...perhaps it only got into master? let me find it

@jquense
Copy link
Contributor

jquense commented Jun 14, 2017

arg, the problem with so much time between these, I forgot that this was also added to master: https://github.com/facebook/react/pull/6648/files

jquense added a commit to jquense/react that referenced this issue Jun 14, 2017
@gaearon
Copy link
Collaborator

gaearon commented Jun 14, 2017

Thanks! Do you remember if there was anything else, or we can cut 15.6.1 with this?

@jquense
Copy link
Contributor

jquense commented Jun 14, 2017

Should be it, at least in terms of changes i've made. I didn't hear about any other issues so I don't think there was anything else added...

@flarnie
Copy link
Contributor

flarnie commented Jun 14, 2017

I'll cherry-pick it and cut 15.6.1 now. Thanks @jquense and @gaearon ~

@flarnie
Copy link
Contributor

flarnie commented Jun 14, 2017

Just an update - we're waiting to cut 15.6.1 until a fix is in for #9963. Will release it either way within a day.

@gaearon
Copy link
Collaborator

gaearon commented Jun 15, 2017

Should be fixed in 15.6.1. Please verify.

@gaearon gaearon closed this as completed Jun 15, 2017
@benbonnet
Copy link

benbonnet commented Jun 15, 2017

not sure if the issue is related, but having this error on safari desktop (version 9.1.1); both with react 15.6.0 and 15.6.1 on regular input fields (email and password types). it happens at load time, and also everytime onchange fires

@gaearon
Copy link
Collaborator

gaearon commented Jun 16, 2017

Please provide a minimal example (e.g. on jsfiddle) that consistently reproduces the issue with 15.6.1 and Safari 9.1.1.

@badtant
Copy link
Author

badtant commented Jun 16, 2017

@gaearon my reported bug is confirmed fixed

@JulianSuringa
Copy link

I experience this error I replicate in safari 9.1 react version 15.6.0 and 15.6.1

@ts-oogie
Copy link

I also experience this in Safari 9.1.2

@gaearon
Copy link
Collaborator

gaearon commented Sep 20, 2017

It doesn’t help to comment on closed issues. In most cases people don’t look at them because the old problem was solved. When you start experiencing an issue similar to an old issue, please file a new one so that the maintainers can keep track of it, and provide all the necessary details.

It appears that someone did: #10755. If you could share more information about the versions you use, and the reproducing cases there, that would be splendid!

@JulianSuringa
Copy link

Confirm fix safari 9.1.3 for react version 5.6.1 and react-dom 15.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants