-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump fbjs to 0.9.x #8898
Comments
Can you try to send a PR that updates it? I’m not sure what changed in fbjs. |
Not worth doing yet. Follow along in the fbjs issue before anything is done. I'll update the changelog there as I've done in the past so it's easy to determine what has changed. |
@zpao Still not a good time? |
Was chatting with @sophiebits about this a couple weeks ago, were planning on getting to it after 16 launched… so I guess that's now 😀 Let's try to knock that out next week. |
@zpao Still wanna do it? |
any update on this? |
@adamnoakes the fbjs dependency was removed entirely in #13069. |
Ah. It has! I believe this can be closed. Thanks for the ping! |
Probably lots of React apps depend on babel-runtime, perhaps directly or maybe indirectly. This can problematic, though, because it can cause such apps to depend on two versions of core-js:
These two versions aren't semver compatible, so it means a project that depends on babel-runtime and also React will have two copies of core-js in use. A concrete example of this is a React app that also depends on Relay. There are probably many other such examples, though. It'd be nice to collapse this dependency into a single version of core-js.
React could bump its dependency to the latest fbjs which is fbjs 0.9.0-alpha.1. That's alpha right now, but it's been alpha for 7 months and probably you guys can arrange a stable release if you want to.
See also:
The text was updated successfully, but these errors were encountered: