Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click handlers triggered on disabled buttons containing elements (Chrome) #8827

Closed
troch opened this issue Jan 19, 2017 · 3 comments
Closed

Comments

@troch
Copy link

troch commented Jan 19, 2017

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

On current version of React (15.4.0), in Chrome and Opera, buttons with a click handler and an element inside them (i.e. not only a text node) get their click handler triggered on click when disabled.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/reactjs/69z2wepo/).

http://codepen.io/anon/pen/MJJNpj

What is the expected behavior?

Both buttons should not react to click events.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

React (15.4.0), Chrome (v55). Was working in React 15.3.x.

@aweary
Copy link
Contributor

aweary commented Jan 19, 2017

Hey @troch, this issue was actually just filed (with the same Codepen) in #8826. See my comment there #8826 (comment). In summary, it was resolved in 15.4.1. Hope that helps!

@aweary aweary closed this as completed Jan 19, 2017
@troch
Copy link
Author

troch commented Jan 19, 2017

Oops sorry, that's my coworker. Misunderstanding.

@aweary
Copy link
Contributor

aweary commented Jan 19, 2017

I figured, no worries 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants