Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC(ish): Ship 15.1.0 and 15.0.3 as is #6803

Closed
zpao opened this issue May 19, 2016 · 5 comments
Closed

RFC(ish): Ship 15.1.0 and 15.0.3 as is #6803

zpao opened this issue May 19, 2016 · 5 comments

Comments

@zpao
Copy link
Member

zpao commented May 19, 2016

We have a 15.0.3-dev branch and a 15.1.0-dev branch (each published as an alpha). React Native is using 15.1.0-alpha in master and soon to be (already cut?) 0.27-rc. Ideally we wouldn't ship 15.1.0 as is and would get more into it, however it's a real risk to RN to churn while they're in RC. While we could say "that's tough shit, you used an alpha", that's really not cool, we're all a big happy family and we should work together ♥️ (and we told them to use an alpha).

So even if I don't think we should do it in an ideal work, pragmatically we should probably just publish what we already have as final. Since we have 15.0.3 with patch fixes and 15.1.0 on top of that, we can ship both easily.

15.0.3 changes: 846b5ea...d8d6c7a
15.1.0 changes (on top of 15.0.3): d8d6c7a...7da8884

Longer term I don't think shipping and maintaining multiple releases is really tenable for us so it's doubtful we'd ship 15.0.4 (outside of a security release). We will need to properly plan what our cadence is and consider a train-like model. That's tangential to the decision here though so I'll write this down my thoughts on this later and we can discuss wherever that is.

A couple related discussions: #6738 & facebook/react-native#7385

@zpao
Copy link
Member Author

zpao commented May 19, 2016

cc @ide because I'm pretty sure you're on board.

@ide
Copy link
Contributor

ide commented May 19, 2016

@zpao thanks - this works for RN.

On a tangent - assuming 15.1.0 follows semver, it should be fully compatible with everyone depending on ^15.0.0 so there's no need for 15.0.4. Multiple releases are necessary only when bumping the major version.

@gaearon
Copy link
Collaborator

gaearon commented May 19, 2016

We need to add #6753 to 15.1.0. It fixes a memory leak I introduced earlier.

@zpao
Copy link
Member Author

zpao commented May 19, 2016

Alright, going to just ship 15.1.0 as is with the additional fix. Even though 15.0.3 is ready it's really unlikely that we'll be following that pattern of parallel patch & minor so no point starting now.

@ide Yup, but there's always risk, especially since semver gets hard to define around the edges. I was just considering the option to provide an out for people who want a smaller set of changes.

@zpao zpao closed this as completed May 19, 2016
@gaearon
Copy link
Collaborator

gaearon commented May 19, 2016

#6752 is another fix that needs to get into 15.1.0.

@zpao zpao mentioned this issue May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants